Skip to content

potential memory leak #225

@viennadd

Description

@viennadd

In function UPNP_CheckPinholeWorking,

	CheckPinholeWorkingArgs = calloc(4, sizeof(struct UPNParg));   // memory allocated here
	if(CheckPinholeWorkingArgs == NULL)
		return UPNPCOMMAND_MEM_ALLOC_ERROR;
	CheckPinholeWorkingArgs[0].elt = "UniqueID";
	CheckPinholeWorkingArgs[0].val = uniqueID;
	buffer = simpleUPnPcommand(-1, controlURL, servicetype,
	                           "CheckPinholeWorking", CheckPinholeWorkingArgs, &bufsize);
	if(!buffer)         // if this if expression take true block, the previous allocated CheckPinholeWorkingArgs will not be freed.
		return UPNPCOMMAND_HTTP_ERROR;

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions