Skip to content

Check if end is at or after start#443

Merged
klauspost merged 1 commit intominio:masterfrom
klauspost:check-op-time
Jan 7, 2026
Merged

Check if end is at or after start#443
klauspost merged 1 commit intominio:masterfrom
klauspost:check-op-time

Conversation

@klauspost
Copy link
Collaborator

No description provided.

>If Times t and u both contain monotonic clock readings, the operations t.After(u), t.Before(u), t.Equal(u), t.Compare(u), and t.Sub(u) are carried out using the monotonic clock readings alone
Copy link
Contributor

@ramondeklein ramondeklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't been able to reproduce the issue with these changes. After reverting this patch, it crashed on all my nodes again. So it definitely fixes the issue.

@klauspost
Copy link
Collaborator Author

@ramondeklein Something is most likely up with the clock on the system you are testing.

@klauspost klauspost merged commit 4803926 into minio:master Jan 7, 2026
6 checks passed
@klauspost klauspost deleted the check-op-time branch January 7, 2026 08:57
@ramondeklein
Copy link
Contributor

All nodes are running on the same machine. But it’s WSL2. I have seen negative durations before. Looks like it’s WSL2 related.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants