Fix get to allow --objects 0 (per README)#433
Merged
harshavardhana merged 1 commit intominio:masterfrom Nov 20, 2025
Merged
Conversation
Using `--list-existing` will list at most `--objects` from the
bucket and download them instead of uploading random objects
(set it to 0 to use all object from the listing).
The intent of --objects with --list-existing for the "get" command was
for the special value 0 to represent "list all and use all". This is
correctly implemented for "delete" but "get" was disallowing this
combination.
This fix allows --objects 0 with --list-existing while ensuring the
object count is >= 1 without --list-existing and still not negative when
--list-existing is supplied.
klauspost
approved these changes
Nov 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Community Contribution License
All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.
Description
This fix allows --objects 0 with --list-existing while ensuring the object count is >= 1 without --list-existing and still not negative when --list-existing is supplied.
Motivation and Context
The intent of --objects with --list-existing for the "get" command was for the special value 0 to represent "list all and use all". This is correctly implemented for "delete" but "get" was disallowing this combination.
How to test this PR?
Ensure there's some objects in the specified bucket and run "warp get" with --list-existing and --objects 0.
Types of changes
Checklist: