Highlight the danger of data being cleaned#426
Merged
klauspost merged 2 commits intominio:masterfrom Nov 6, 2025
Merged
Conversation
I made a big mistake locally, that I suspect others might fall victim to. As such, I propose to highlight the danger of data being wiped with the warning-format. If that is to bold, then I suggest the note variant. Either way, I would argue something needs to be done to warn users of potential data loss, and not in the form of a last sentence in an arbitrary paragraph with an italicized "not".
klauspost
reviewed
Nov 6, 2025
Collaborator
klauspost
left a comment
There was a problem hiding this comment.
Not sure it will make any difference. Seems like copium ;)
Anyway, I don't see any problem with it. Let's make it a bit clearer as a standalone sentence.
klauspost
approved these changes
Nov 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made a big mistake locally, that I suspect others might fall victim to. As such, I propose to highlight the danger of data being wiped with the warning-format. If that is to bold, then I suggest the note variant. Either way, I would argue something needs to be done to warn users of potential data loss, and not in the form of a last sentence in an arbitrary paragraph with an italicized "not".