fix: fatal errors break the terminal due to incorrect bubble tea shutdown#422
Merged
klauspost merged 2 commits intominio:masterfrom Oct 15, 2025
Merged
Conversation
marktheunissen
commented
Oct 7, 2025
| // Clean up UI if one is registered | ||
| if u := globalUI.Load(); u != nil { | ||
| u.Wait() | ||
| } |
Contributor
Author
There was a problem hiding this comment.
It's not ideal, but the problem is fatalIf does exit(). Another solution would be to refactor fatalIf itself, but it's used everywhere...
harshavardhana
approved these changes
Oct 7, 2025
klauspost
approved these changes
Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the correct ui.Wait() call when exiting on a fatal log, to prevent the terminal cursor from disappearing, as well as other problems that make the terminal unusable:
Before:
After: