ObjectWriteResponse: return checksums if any #1609
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently `PutObject`, `CopyObject`, `CompleteMultipartUpload` could return checksums, but client api for `CopyObjectResult` and `ObjectWriteResponse` does not return it. This commit adds checksums to `CopyObjectResult` and `ObjectWriteResponse` to allow users to get checksums if any. Close minio#1608 References: <https://docs.aws.amazon.com/AmazonS3/latest/API/API_PutObject.html#API_PutObject_ResponseSyntax> <https://docs.aws.amazon.com/AmazonS3/latest/API/API_CompleteMultipartUpload.html#API_CompleteMultipartUpload_ResponseSyntax> <https://docs.aws.amazon.com/AmazonS3/latest/API/API_CopyObject.html#API_CopyObject_ResponseSyntax>
harshavardhana
previously approved these changes
Jan 2, 2025
balamurugana
requested changes
Jan 4, 2025
| this.versionId = versionId; | ||
| } | ||
|
|
||
| public ObjectWriteResponse( |
Member
There was a problem hiding this comment.
- By default, populate checksums from headers
- Accept
CopyObjectResultas an additional argument and populate checksums - Accept
CompleteMultipartUploadResultas an additional argument and populate checkums
1. By default, populate checksums from headers 2. Accept CopyObjectResult as an additional argument and populate checksums 2. Accept CompleteMultipartUploadResult as an additional argument and populate checksums <minio#1609 (comment)>
Member
|
@kzhsw Avoid refreshing/sending PR without testing locally. |
Contributor
Author
Sorry, just had a hard time with my local gradle. |
balamurugana
approved these changes
Jan 6, 2025
minio-trusted
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
PutObject,CopyObject,CompleteMultipartUploadcould return checksums, but client api forCopyObjectResultandObjectWriteResponsedoes not return it. This commit adds checksums toCopyObjectResultandObjectWriteResponseto allow users to get checksums if any.Close #1608
References:
https://docs.aws.amazon.com/AmazonS3/latest/API/API_PutObject.html#API_PutObject_ResponseSyntax
https://docs.aws.amazon.com/AmazonS3/latest/API/API_CompleteMultipartUpload.html#API_CompleteMultipartUpload_ResponseSyntax
https://docs.aws.amazon.com/AmazonS3/latest/API/API_CopyObject.html#API_CopyObject_ResponseSyntax