tests: remove deprecated --config-dir MinIO server argument#1524
Merged
Conversation
balamurugana
approved these changes
Jan 17, 2024
harshavardhana
approved these changes
Jan 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sort-of-a follow-up to #1523 and #1522
As stated in https://min.io/docs/minio/linux/reference/minio-server/minio-server.html:
The functional tests on master branch still use the removed --config-dir property. Due to this, the test instance of Min.io, which was intended to run with TLS, runs without TLS. Therefore the tests which were intended to call the TLS instance fail with an SSL handshake error.
I aligned the parameter in line with the docs. The TLS instance should start with TLS enabled and the functional tests should be back in order.