Add {add,update,delete,list}ServiceAccount and getServiceAccountInfo Admin APIs by dormanze · Pull Request #1505 · minio/minio-java

dormanze · 2023-10-24T12:11:04Z

…-java into addServiceAccount * 'addServiceAccount' of https://github.com/dormanze/minio-java: Update okhttp to fix CVE-2023-3635 (minio#1503)

Kress6 · 2023-10-30T12:15:38Z

Hi guys,

Is there any progress on the review?
I was already planning to contribute myself. 😊 But I see that the pull request is ready. I would really like to see this feature in a new lib release.

dormanze · 2023-10-30T12:37:16Z

Hi guys,

Is there any progress on the review? I was already planning to contribute myself. 😊 But I see that the pull request is ready. I would really like to see this feature in a new lib release.

Can you review my code and approved my changes?😊

Kress6 · 2023-10-30T12:43:56Z

Can you review my code and approved my changes?😊

Yes. I can review, but I don't have write access. 😊

balamurugana · 2023-11-03T05:30:24Z

Is the PR #1500 unrelated to this PR?

dormanze · 2023-11-03T05:34:25Z

Is the PR #1500 unrelated to this PR?

This PR contains the content of PR #1500 and complements the implementation of other related APIs.

balamurugana · 2023-11-03T05:37:59Z

Is the PR #1500 unrelated to this PR?

This PR contains the content of PR #1500 and complements the implementation of other related APIs.

You could close the other PR?

dormanze · 2023-11-03T05:40:27Z

Is the PR #1500 unrelated to this PR?

This PR contains the content of PR #1500 and complements the implementation of other related APIs.

You could close the other PR?

PR #1500 was not initiated by me, you can close PR #1500 and # 1498 after incorporating my PR.😊

dormanze · 2023-11-03T09:22:21Z

@balamurugana Could you take a moment to review my PR? I'm very grateful.

balamurugana · 2023-11-03T09:23:44Z

@balamurugana Could you take a moment to review my PR? I'm very grateful.

I am on it

Resolve conversation

…-java into addServiceAccount * 'addServiceAccount' of https://github.com/dormanze/minio-java: Upgrade gradle, it's dependencies and project dependencies (minio#1507)

Kress6 · 2023-11-08T14:47:09Z

Hi, @dorma
Have you tried using addServiceAccount method with policy? I got exeption. Although a similar code works in Go.

Exception:

java.lang.RuntimeException: Request failed with response: {"Code":"XMinioMalformedIAMPolicy","Message":"json: cannot unmarshal string into Go value of type policy.subPolicy","Resource":"/minio/admin/v3/add-service-account","RequestId":"***","HostId":"***"}

	at io.minio.admin.MinioAdminClient.execute(MinioAdminClient.java:218)
	at io.minio.admin.MinioAdminClient.addServiceAccount(MinioAdminClient.java:723)

Code:

        MinioAdminClient minioAdminClient = MinioAdminClient.builder()
                .endpoint("http://127.0.0.1:9000/")
                .credentials("test", "password")
                .build()
        String policy = """
            {
                "Statement": [
                    {
                        "Action": "s3:GetObject",
                        "Effect": "Allow",
                        "Principal": "*",
                        "Resource": "arn:aws:s3:::my-bucketname/myobject*"
                    }
                ],
                "Version": "2012-10-17"
            }""";
        Credentials credentials = minioAdminClient.addServiceAccount("user",
                "name",
                "secretKey",
                "accessKey",
                policy,
                null,
                null);

Kress6 · 2023-11-09T11:01:05Z

Hi, @dormanze
I also get NPE if I pass an empty expiration

Caused by: java.lang.NullPointerException: text
	at java.base/java.util.Objects.requireNonNull(Objects.java:235)
	at java.base/java.time.format.DateTimeFormatter.parse(DateTimeFormatter.java:1951)
	at java.base/java.time.ZonedDateTime.parse(ZonedDateTime.java:600)
	at io.minio.messages.ResponseDate.fromString(ResponseDate.java:57)
	at io.minio.admin.MinioAdminClient.addServiceAccount(MinioAdminClient.java:723)

Maybe you need to unmarshal json response and map it into Credentials.

dormanze · 2023-11-10T06:11:06Z

Hi, @dorma Have you tried using addServiceAccount method with policy? I got exeption. Although a similar code works in Go.

Exception:

java.lang.RuntimeException: Request failed with response: {"Code":"XMinioMalformedIAMPolicy","Message":"json: cannot unmarshal string into Go value of type policy.subPolicy","Resource":"/minio/admin/v3/add-service-account","RequestId":"***","HostId":"***"}

	at io.minio.admin.MinioAdminClient.execute(MinioAdminClient.java:218)
	at io.minio.admin.MinioAdminClient.addServiceAccount(MinioAdminClient.java:723)

Code:

        MinioAdminClient minioAdminClient = MinioAdminClient.builder()
                .endpoint("http://127.0.0.1:9000/")
                .credentials("test", "password")
                .build()
        String policy = """
            {
                "Statement": [
                    {
                        "Action": "s3:GetObject",
                        "Effect": "Allow",
                        "Principal": "*",
                        "Resource": "arn:aws:s3:::my-bucketname/myobject*"
                    }
                ],
                "Version": "2012-10-17"
            }""";
        Credentials credentials = minioAdminClient.addServiceAccount("user",
                "name",
                "secretKey",
                "accessKey",
                policy,
                null,
                null);

I've fixed it. Please try again.

dormanze · 2023-11-10T06:11:11Z

Hi, @dormanze I also get NPE if I pass an empty expiration

Caused by: java.lang.NullPointerException: text
	at java.base/java.util.Objects.requireNonNull(Objects.java:235)
	at java.base/java.time.format.DateTimeFormatter.parse(DateTimeFormatter.java:1951)
	at java.base/java.time.ZonedDateTime.parse(ZonedDateTime.java:600)
	at io.minio.messages.ResponseDate.fromString(ResponseDate.java:57)
	at io.minio.admin.MinioAdminClient.addServiceAccount(MinioAdminClient.java:723)

Maybe you need to unmarshal json response and map it into Credentials.

I've fixed it. Please try again.

Kress6 · 2023-11-15T07:43:07Z

It works now, thanks

dormanze · 2023-11-17T06:06:32Z

@balamurugana Could you take a moment to review my pr again? I'm very grateful.

dormanze · 2023-11-30T12:14:08Z

@harshavardhana I'd appreciate a little help reviewing my pr.

jean-humann · 2024-01-30T17:32:16Z

@harshavardhana @balamurugana When could we expect to have this commit released with a new version of minio jdk please ?

dormanze added 6 commits October 24, 2023 19:59

add service account API

1a23b5a

Update MinioAdminClient.java

460973c

Merge branch 'master' into addServiceAccount

ecf9f60

add upgrade api

6e058f2

Merge branch 'addServiceAccount' of https://github.com/dormanze/minio…

920db23

…-java into addServiceAccount * 'addServiceAccount' of https://github.com/dormanze/minio-java: Update okhttp to fix CVE-2023-3635 (minio#1503)

Modifying comment information

6c7cff5

balamurugana requested changes Nov 3, 2023

View reviewed changes

Resolve conversation

2807755

Resolve conversation

dormanze requested a review from balamurugana November 6, 2023 09:38

balamurugana and others added 3 commits November 6, 2023 15:11

Merge branch 'master' into addServiceAccount

6a47a64

Update MinioAdminClient.java

23b6e7e

Merge branch 'addServiceAccount' of https://github.com/dormanze/minio…

bdfa5fc

…-java into addServiceAccount * 'addServiceAccount' of https://github.com/dormanze/minio-java: Upgrade gradle, it's dependencies and project dependencies (minio#1507)

Update MinioAdminClient.java

ceed0c7

Merge branch 'master' into addServiceAccount

4cfd751

balamurugana requested changes Nov 17, 2023

View reviewed changes

Update MinioAdminClient.java

57fd20f

dormanze requested a review from balamurugana November 18, 2023 02:33

Update MinioAdminClient.java

797b633

balamurugana requested changes Nov 18, 2023

View reviewed changes

resolve review comments

565af0f

dormanze requested a review from balamurugana November 18, 2023 07:16

balamurugana requested changes Nov 18, 2023

View reviewed changes

dormanze added 3 commits November 18, 2023 17:38

Update MinioAdminClient.java

6bab095

Update MinioAdminClient.java

9ef1366

Update MinioAdminClient.java

2a8aa74

dormanze requested a review from balamurugana November 18, 2023 09:51

balamurugana changed the title ~~AdminClient: add service account API~~ Add {add,update,delete,list}ServiceAccount and getServiceAccountInfo Admin APIs Nov 18, 2023

balamurugana approved these changes Nov 18, 2023

View reviewed changes

harshavardhana approved these changes Dec 2, 2023

View reviewed changes

harshavardhana merged commit 5c2854f into minio:master Dec 2, 2023

dormanze deleted the addServiceAccount branch October 14, 2024 08:04

Conversation

dormanze commented Oct 24, 2023

Uh oh!

Kress6 commented Oct 30, 2023

Uh oh!

dormanze commented Oct 30, 2023

Uh oh!

Kress6 commented Oct 30, 2023

Uh oh!

balamurugana commented Nov 3, 2023

Uh oh!

dormanze commented Nov 3, 2023

Uh oh!

balamurugana commented Nov 3, 2023

Uh oh!

dormanze commented Nov 3, 2023

Uh oh!

dormanze commented Nov 3, 2023

Uh oh!

balamurugana commented Nov 3, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Kress6 commented Nov 8, 2023

Uh oh!

Kress6 commented Nov 9, 2023

Uh oh!

dormanze commented Nov 10, 2023

Uh oh!

dormanze commented Nov 10, 2023

Uh oh!

Kress6 commented Nov 15, 2023

Uh oh!

dormanze commented Nov 17, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dormanze commented Nov 30, 2023

Uh oh!

jean-humann commented Jan 30, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants