Skip to content
This repository was archived by the owner on Feb 13, 2026. It is now read-only.

add go modules file and start running go 1.11 style builds#7354

Merged
harshavardhana merged 1 commit intominio:masterfrom
wlan0:gomod
Mar 19, 2019
Merged

add go modules file and start running go 1.11 style builds#7354
harshavardhana merged 1 commit intominio:masterfrom
wlan0:gomod

Conversation

@wlan0
Copy link
Contributor

@wlan0 wlan0 commented Mar 11, 2019

@codecov
Copy link

codecov bot commented Mar 11, 2019

Codecov Report

Merging #7354 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7354      +/-   ##
==========================================
+ Coverage   48.07%   48.08%   +<.01%     
==========================================
  Files         297      297              
  Lines       46809    46809              
==========================================
+ Hits        22503    22506       +3     
+ Misses      22245    22244       -1     
+ Partials     2061     2059       -2
Impacted Files Coverage Δ
pkg/certs/certs.go 54.63% <0%> (-4.13%) ⬇️
cmd/bitrot-streaming.go 81.55% <0%> (-0.98%) ⬇️
cmd/posix.go 64.04% <0%> (+0.21%) ⬆️
cmd/fs-v1-helpers.go 68.8% <0%> (+0.61%) ⬆️
cmd/posix-list-dir_unix.go 75% <0%> (+2.63%) ⬆️
cmd/disk-usage.go 78.94% <0%> (+10.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a77a29...0b33341. Read the comment docs.

@wlan0 wlan0 force-pushed the gomod branch 2 times, most recently from a3f5003 to c7daaec Compare March 11, 2019 21:50
@sinhaashish
Copy link
Contributor

@wlan0 please check the travis failure

@wlan0 wlan0 force-pushed the gomod branch 8 times, most recently from 0f672ff to 88342d0 Compare March 15, 2019 22:14
@harshavardhana
Copy link
Member

parquet-go deps has updated @wlan0 can you update that too?

@harshavardhana
Copy link
Member

Ping @sinhaashish

@kannappanr kannappanr requested review from poornas and removed request for sinhaashish March 19, 2019 19:13
@minio-ops
Copy link

Mint Automation

Test Result
mint-compression-xl.sh ✔️
mint-xl.sh ✔️
mint-large-bucket.sh ✔️
mint-compression-dist-xl.sh ✔️
mint-compression-fs.sh ✔️
mint-worm.sh ✔️
mint-fs.sh ✔️
mint-gateway-nas.sh ✔️
mint-dist-xl.sh more...

7354-0b33341/mint-dist-xl.sh.log:

Running with
SERVER_ENDPOINT:      72.28.97.56:32431
ACCESS_KEY:           minio
SECRET_KEY:           ***REDACTED***
ENABLE_HTTPS:         0
SERVER_REGION:        us-east-1
MINT_DATA_DIR:        /mint/data
MINT_MODE:            full
ENABLE_VIRTUAL_STYLE: 0

To get logs, run 'docker cp 5d0772482883:/mint/log /tmp/mint-logs'

(1/14) Running aws-sdk-go tests ... done in 0 seconds
(2/14) Running aws-sdk-java tests ... done in 1 seconds
(3/14) Running aws-sdk-php tests ... done in 45 seconds
(4/14) Running aws-sdk-ruby tests ... done in 4 seconds
(5/14) Running awscli tests ... done in 1 minutes and 51 seconds
(6/14) Running healthcheck tests ... done in 0 seconds
(7/14) Running mc tests ... done in 35 seconds
(8/14) Running minio-dotnet tests ... done in 40 seconds
(9/14) Running minio-go tests ... done in 1 minutes and 14 seconds
(10/14) Running minio-java tests ... done in 2 minutes and 58 seconds
(11/14) Running minio-js tests ... done in 40 seconds
(12/14) Running minio-py tests ... FAILED in 4 minutes and 33 seconds
{
  "args": {
    "object_name": "5c4a9d2c-1c72-416e-8a5e-7c2bd5827aa7",
    "bucket_name": "minio-py-test-e278d560-1cf1-44cd-9b6d-9dc8e98977b9"
  },
  "function": "presigned_get_object(bucket_name, object_name, expires, response_headers, request_date)",
  "duration": 123,
  "status": "FAIL",
  "name": "minio-py:test_presigned_get_object_response_headers",
  "error": "Traceback (most recent call last):\n  File \"/mint/run/core/minio-py/tests.py\", line 1266, in test_presigned_get_object_response_headers\n    returned_content_language = response.headers['Content-Language']\n  File \"/usr/local/lib/python3.5/dist-packages/urllib3/_collections.py\", line 152, in __getitem__\n    val = self._container[key.lower()]\nKeyError: 'content-language'\n\nDuring handling of the above exception, another exception occurred:\n\nTraceback (most recent call last):\n  File \"/mint/run/core/minio-py/tests.py\", line 1888, in main\n    test_presigned_get_object_response_headers(client, log_output)\n  File \"/mint/run/core/minio-py/tests.py\", line 1274, in test_presigned_get_object_response_headers\n    raise Exception(err)\nException: 'content-language'\n",
  "message": "'content-language'"
}

Executed 11 out of 14 tests successfully.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants