T 1164100: Add check for nil request URL#166
Merged
ruchiupgade-mb merged 3 commits intomainfrom Oct 22, 2022
Merged
Conversation
plflanagan
reviewed
Oct 19, 2022
plflanagan
suggested changes
Oct 20, 2022
Contributor
plflanagan
left a comment
There was a problem hiding this comment.
Just one quick change request. Let me know when made and I can quickly re-review.
plflanagan
approved these changes
Oct 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes (pick all that apply):
Summary
In
URLSessionClientif the modifiedRequest URL is nil, the data task was not getting initialized. Because of this The callback is not fired.In this fix we have added a check for nil URL. If the request URL is nil we are initiating a callback with
missingURLerror.Implementation
Test Plan