Skip to content

Allow passing a custom completion queue to ImageDownloader#162

Merged
eneko merged 3 commits intomainfrom
task/image-downloader-queue
Jul 1, 2021
Merged

Allow passing a custom completion queue to ImageDownloader#162
eneko merged 3 commits intomainfrom
task/image-downloader-queue

Conversation

@eneko
Copy link
Copy Markdown
Contributor

@eneko eneko commented Jul 1, 2021

This pull request includes (pick all that apply):

  • Bugfixes
  • New features
  • Breaking changes
  • Documentation updates
  • Unit tests
  • Integration tests
  • Other

Summary

Allow passing a custom operation queue to ImageDownloader to be used when calling the completion callback.

Implementation

  • Add completionQueue parameter to initializer (defaults to nil)
    • If no value is passed, ImageDownloader will behave as before, defaulting to the current operation queue for completion, or main if there is no current queue.
    • When a queue is specified, it will be used instead.

Test Plan

  • Run integration tests

Copy link
Copy Markdown
Contributor

@plflanagan plflanagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@eneko eneko merged commit fdf1e5c into main Jul 1, 2021
@eneko eneko deleted the task/image-downloader-queue branch July 1, 2021 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants