Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new MdMenu dropdown component to the design system, including React implementation, CSS styling, Storybook documentation, and unit tests.
Changes:
- Introduces
MdMenu(Ariakit-based) with grouped items, optional icons, size variants, dividers, and placement. - Adds
menu.css+ CSS README and wires the stylesheet intopackages/css/src/index.css. - Adds Storybook story + Vitest test suite and exports the component/types from
packages/react/src/index.tsx.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| stories/Menu.stories.tsx | Storybook docs + usage examples for the new Menu component |
| packages/react/src/menu/MdMenu.tsx | New Ariakit-based MdMenu React component + public types |
| packages/react/src/menu/tests/MdMenu.test.tsx | Unit tests covering rendering, groups/headings, dividers, sizes, icons, interactions |
| packages/react/src/index.tsx | Exports MdMenu and related types from the package entrypoint |
| packages/css/src/menu/menu.css | New CSS styles for menu popup, items, headings, separators, and size variants |
| packages/css/src/menu/README.md | Standalone CSS documentation for Menu structure/modifiers |
| packages/css/src/index.css | Includes the new menu stylesheet in the CSS bundle |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
Du kan linke opp issuen du løser her! @inmetajacoblarsen
|
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
aurorascharff
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Replace this text with a detailed description of your changes
Checklist before requesting a review
major,minororpatch)stories-folder?packages/react/index.tsx?packages/css/index.css?