Merged
Conversation
Contributor
|
Please set a versioning label of either |
There was a problem hiding this comment.
Pull request overview
Adds a new MdPagination component (React + CSS) and documents it in Storybook, aligning with the provided Figma spec.
Changes:
- Introduces
packages/react/src/pagination/MdPagination.tsxwith desktop/compact rendering, ellipsis handling, and optional custom link rendering. - Adds pagination styling + standalone HTML structure docs under
packages/css/src/pagination/. - Wires the component into public exports (
packages/react/src/index.tsx), CSS bundle (packages/css/src/index.css), and Storybook (stories/Pagination.stories.tsx).
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| stories/Pagination.stories.tsx | Adds Storybook documentation and examples (including asChild link rendering) for the new component. |
| packages/react/src/pagination/MdPagination.tsx | Implements the new pagination component logic and rendering. |
| packages/react/src/index.tsx | Exports MdPagination and MdPaginationProps from the React package entrypoint. |
| packages/css/src/pagination/pagination.css | Adds styling for pagination layout, buttons, compact mode, and responsive behavior. |
| packages/css/src/pagination/README.md | Documents the standalone HTML structure for the pagination CSS. |
| packages/css/src/index.css | Includes the new pagination stylesheet in the CSS package bundle. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…lity with aria attributes
IngSchei
approved these changes
Feb 18, 2026
…and add comprehensive tests
….config.ts for type checking
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…d NavButton as separate components
inmetajacoblarsen
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Add new MdPagination as per Figma spec: https://www.figma.com/design/6BUqOC0xQZz6AggPvI2iSR/Komponenter?node-id=13262-8&p=f&t=DXfkBY7c2RKmiezZ-0
We need render props here since we have multiple children to render, and cant use asChildContent only.
Tested in own project with asChild and searchparams and <Link: https://github.com/miljodir/ac-avdekl/pull/1252/changes:
Checklist before requesting a review
major,minororpatch)stories-folder?packages/react/index.tsx?packages/css/index.css?