Fix build-CI + add badges to readme.md #217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
RobTillaart
commented
Jun 3, 2022
- add badges to readme.md to easy see the results of build-CI (e.g. for updates / PR testing)
- fix broken build CI,
- platforms tested (AVR, SAM, SAMD, ESP2866) these compile all examples.
- ESP32 gave problems (need to investigate)
- LINT test OK
- JSON test OK
- unit tests can not be enabled
- build-CI environment cannot find "util/crc16.h" (need to investigate)
Contributor
Author
|
@milesburton |
Owner
|
Cleaning house. Let me reopen
…On Fri, 3 Jun 2022 at 09:40, Rob Tillaart ***@***.***> wrote:
@milesburton <https://github.com/milesburton>
Why was this PR closed, it is the squashed version of the other PR.
—
Reply to this email directly, view it on GitHub
<#217 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJGHM77PCDLA6BZNAE57JTVNHAHRANCNFSM5XXZFGFQ>
.
You are receiving this because you were mentioned.Message ID:
<milesburton/Arduino-Temperature-Control-Library/pull/217/c1145735786@
github.com>
|
Owner
|
Apologies. Back to you @RobTillaart |
Contributor
Author
|
Understand, cleaning up is a good thing to do. |
Contributor
Author
|
Note about building ESP32 in build-CI - It fails on a low level gpio_mux call in OneWire. |
Contributor
Author
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.