Skip to content

Bugfix for mila code in WSL#131

Merged
lebrice merged 7 commits intomasterfrom
fix_mila_code_WSL
Oct 17, 2024
Merged

Bugfix for mila code in WSL#131
lebrice merged 7 commits intomasterfrom
fix_mila_code_WSL

Conversation

@lebrice
Copy link
Copy Markdown
Collaborator

@lebrice lebrice commented Oct 11, 2024

When a user launches mila code from WSL, it should end up running powershell.exe code (...), otherwise the vscode window opens a local file (that doesn't exist) instead of opening on the remote.

This fixes a bug whereby the running_inside_WSL function wasn't being called anymore in mila code.

Signed-off-by: Fabrice Normandin normandf@mila.quebec

Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
- PyCQA/docformatter#289
- PyCQA/docformatter#287

Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice lebrice marked this pull request as ready for review October 11, 2024 16:00
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 11, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.16%. Comparing base (9b4a7cd) to head (029e9b2).
⚠️ Report is 29 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #131      +/-   ##
==========================================
+ Coverage   72.93%   74.16%   +1.23%     
==========================================
  Files          15       17       +2     
  Lines        2176     2311     +135     
==========================================
+ Hits         1587     1714     +127     
- Misses        589      597       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lebrice lebrice merged commit 3096054 into master Oct 17, 2024
@lebrice lebrice deleted the fix_mila_code_WSL branch October 17, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants