Skip to content

/VerusCoin/src/cryptoconditions/src/include/ed25519/src/seed.c#64

Closed
monkins1010 wants to merge 352 commits intomiketout:masterfrom
VerusCoin:master
Closed

/VerusCoin/src/cryptoconditions/src/include/ed25519/src/seed.c#64
monkins1010 wants to merge 352 commits intomiketout:masterfrom
VerusCoin:master

Conversation

@monkins1010
Copy link
Copy Markdown

@monkins1010 monkins1010 commented Jan 5, 2020

seed.c to be changed to

    size_t fread_size = fread(seed, 1, 32, f);
      
    fclose(f);
    if (fread_size == 0) {
        return 1;
    }

As fread was not storing its returned size count into anything and the new compiler warnings flag up an unused variable.  Maybe 

`c if (fread_size != 32) return 1;` ??

not sure how much it should be reading, from the fread documentation:

### Return Value
The total number of elements successfully read is returned.
If this number differs from the count parameter, either a reading error occurred or the end-of-file was reached while reading. In both cases, the proper indicator is set, which can be checked with ferror and feof, respectively.
If either size or count is zero, the function returns zero and both the stream state and the content pointed by ptr remain unchanged.
size_t is an unsigned integral type.

Asherda and others added 30 commits November 14, 2019 22:27
Asherda and others added 29 commits December 29, 2019 18:45
# Conflicts:
#	src/cryptoconditions/src/threshold.c
remove flags not supported by gcc versions under 7
Fixes for strict warnings as errors
Set -march and -mtune to armv8.1-a+crypto for ARM builds
Integrate z_import and z_exportviewingkey from Komodo/Pirate implementation with same API format to enable confidential, verifiable, and transparent voting
do not use '-Wno-builtin-declaration-mismatch on GCC <v7
do not use '-Wno-builtin-declaration-mismatch on GCC <v7
@miketout miketout closed this Jan 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants