Skip to content

Remove Deprecated Komodo Cryptoconditions#391

Merged
miketout merged 68 commits intomiketout:devfrom
Alrighttt:remove-dead-ccs
Nov 20, 2025
Merged

Remove Deprecated Komodo Cryptoconditions#391
miketout merged 68 commits intomiketout:devfrom
Alrighttt:remove-dead-ccs

Conversation

@Alrighttt
Copy link
Copy Markdown

@Alrighttt Alrighttt commented Oct 24, 2025

Opening the PR as a draft to spark discussion. Should we target removing all dead code? I don't mind occasionally putting time towards this as a project if we want to fully remove any and all dead code originating from Komodo. We could additionally remove quite a bit of code related to Komodo's deprecated "PAX" features.

Changelog:

  • Removes deprecated cryptoconditions originating from Komodo.
  • Removes cryptoconditions gtest framework tests. Leaves test-komodo/test_cryptoconditions.cpp in place as an example case.
  • Removes a duplicated definition for libbitcoin_wallet.a within Makefile.am
  • Removes various code related to various deprecated RPC methods: paxprices, paxprice, kvsearch, kvupdate, paxpending, MoMoMdata, calc_MoM, height_MoM, assetchainproof, crosschainproof, getNotarisationsForBlock, scanNotarisationsDB, migrate_converttoexport, migrate_createimporttransaction, migrate_completeimporttransaction, getbalance64
  • Removes CScript::IsCoinImport. This was previously set to always return false. All logic referencing it has now been removed. This change requires thorough review of the changes within main.cpp.
  • Removes various dead code helpers and utility functions from cc/CCutils.cpp

This test-komodo/test_cryptoconditions.cpp is left in place to serve as an example for how to implement a new gtest within the test-komodo binary. If we want to remove this, we could remove the entire test framework, but I believe it's useful for future testing.

…guana_rwnum, iguana_rwbignum; remove unused extern CCerror
@Alrighttt Alrighttt marked this pull request as ready for review October 28, 2025 14:39
@miketout miketout merged commit 29a18ad into miketout:dev Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants