Remove Deprecated Komodo Cryptoconditions#391
Merged
miketout merged 68 commits intomiketout:devfrom Nov 20, 2025
Merged
Conversation
reintroduce deleted tests This reverts commit 04ff1a5.
…guana_rwnum, iguana_rwbignum; remove unused extern CCerror
…Payout, ImportPayout, ImportCoin
…orary stub in place for komodo_interestsum() function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening the PR as a draft to spark discussion. Should we target removing all dead code? I don't mind occasionally putting time towards this as a project if we want to fully remove any and all dead code originating from Komodo. We could additionally remove quite a bit of code related to Komodo's deprecated "PAX" features.
Changelog:
test-komodo/test_cryptoconditions.cppin place as an example case.libbitcoin_wallet.awithinMakefile.amCScript::IsCoinImport. This was previously set to always return false. All logic referencing it has now been removed. This change requires thorough review of the changes withinmain.cpp.cc/CCutils.cppThis
test-komodo/test_cryptoconditions.cppis left in place to serve as an example for how to implement a new gtest within thetest-komodobinary. If we want to remove this, we could remove the entire test framework, but I believe it's useful for future testing.