Fix mistake in build-mac-arm.sh MACOSX_DEPLOYMENT_TARGET variable#390
Merged
miketout merged 1 commit intomiketout:devfrom Oct 27, 2025
Merged
Fix mistake in build-mac-arm.sh MACOSX_DEPLOYMENT_TARGET variable#390miketout merged 1 commit intomiketout:devfrom
miketout merged 1 commit intomiketout:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a mistake in
MACOSX_DEPLOYMENT_TARGETvariable, and ensures the variable is also set while building depends. This ensures thekomodo-testbinary is built using the same minimum OSX version asverusd.The previous
10.5value is invalid on ARM builds which was resulting in15.0being used as default.