Fix hashfile function to return consistent file hashes in MacOS#341
Merged
miketout merged 2 commits intomiketout:devfrom Feb 19, 2025
Merged
Fix hashfile function to return consistent file hashes in MacOS#341miketout merged 2 commits intomiketout:devfrom
miketout merged 2 commits intomiketout:devfrom
Conversation
…with `read` to ensure more consistent file reading
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
std::ifstream::readsomefunction is not guaranteed to read all the requested bytes into the buffer on certain files or systems because it reads only what is readily available. This behavior can lead to inconsistencies, such as a calculated hash of a file being different on macOS compared to other systems.