Merged
Conversation
(cherry picked from commit bitcoin/bitcoin@037159c) Zcash: Adapted for our lack of direct headers announcement. (cherry picked from commit zcash/zcash/df24ea9bd29e13c018c389e32f8e6c669786b173)
vToFetch is never used after declaration. When checked if not empty, evaluation is always false. Best case scenario this is optimized by the compiler, worst case it wastes cpu cycles. It should be removed either way. (cherry picked from commit bitcoin/bitcoin@c707ca8) Zcash: Adjusted for us not having backported various refactors. (cherry picked from commit 814e320)
Headers-first is the primary method of announcement on the network. If a node fell back sending blocks by inv, it's probably for a re-org. The final block hash provided should be the highest, so send a getheaders and then fetch the blocks we need to catch up. (cherry picked from commit bitcoin/bitcoin@7467366) Zcash: Adjusted for us not having backported various refactors. (cherry picked from commit zcash/zcash/52cd44c7c80f0255fe6a5b8dc73c8343aade2501)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from zcash#6927