Merged
Conversation
minor fixes to sendcurrency help
Clarifying change to takeoffer help, now conforms with makeoffer help
Update testnet ports, depends
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Download the signature file first and then the archive itself drastically reduces the chance of a new bootstrap being generated before downloading the 2nd (large) file, resulting in a non-matching signature file and bootstrap archive.
Although this is an edge case that would only happen when a new bootstrap is generated while downloading the archive, the chance of encountering this case rises when the chain grows in size or the user has a slow download speed. Since the bootstrap archive is regenerated on a daily basis, the chance of somebody running into this is a recurring chance.