Issue #360 - Support for Table attribute#435
Merged
mikependon merged 1 commit intomikependon:masterfrom May 16, 2020
Merged
Conversation
Owner
|
To be honest, I really liked this PR. Big thanks mate! :) Let me make some minor comments and let us collaborate further there. |
mikependon
reviewed
May 15, 2020
mikependon
reviewed
May 15, 2020
mikependon
reviewed
May 15, 2020
mikependon
added a commit
that referenced
this pull request
May 16, 2020
cwaldron
added a commit
to cwaldron/RepoDb
that referenced
this pull request
May 16, 2020
…ng to favor Map & Primary attributes.
cwaldron
added a commit
to cwaldron/RepoDb
that referenced
this pull request
May 16, 2020
…iting to favor Map & Primary attributes.
Owner
Contributor
Author
|
Hey @mikependon I just noticed this. Is this still an issue. I'll take a look if it is. Cheers. |
Owner
Contributor
Author
|
Thanks @mikependon for taking care of this. Great work as always. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I got tired of waiting for @lauw to create a PR so I did it myself. Let me know what you think. I added support for TableAttribute, ColumnAttribute, & KeyAttribute using the attributes as defined in System.ComponentModel.Annotations.
Cheers.