Skip to content

Don't use a logical or for setting header and footer. #147

@tandrewnichols

Description

@tandrewnichols

Regarding these lines: https://github.com/miickel/gulp-angular-templatecache/blob/master/index.js#L173-L174

Could you use something like 'templateHeader' in options ? options.templateHeader : TEMPLATE_HEADER for these? Because an empty string is falsey, which means I can't tell this module to use no header and footer and supply it myself later.

More specifically, this:

.pipe(ngtemplates({ header: '', footer: '' }))

still adds a header and footer.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions