Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: miekg/dns
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.1.46
Choose a base ref
...
head repository: miekg/dns
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.1.47
Choose a head ref
  • 4 commits
  • 7 files changed
  • 2 contributors

Commits on Mar 2, 2022

  1. Id check tests: stop using Exchange (#1343)

    Using Exchange doesn't add anything, as it just wraps client.Exchange
    with a default client.
    
    Remove them and speed up the tests, goes from 3s to 1s (for the entire
    test suite).
    
    Signed-off-by: Miek Gieben <miek@miek.nl>
    miekg authored Mar 2, 2022
    Configuration menu
    Copy the full SHA
    af1ebf5 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2022

  1. Add indentityHash for algos that don't need hashing (#1340)

    This adds hash.go and creates a identityHash that is used for algorithms
    that do their own hashing (ED25519) for instance.
    
    This unifies the hash variable naming between dnssec and sig(0) signing
    and removes the special casing that existed for ED25519.
    
    This unifies the variable naming between sig(0) and dnssec signing and
    verifying.
    
    I didn't want to used crypto.RegisterHash as not to fiddle with the
    global namespaces of hashes, so the value of '0' from AlgorithmsToHash
    is handled specially in dnssec and sig(0) code.
    
    Note that ED448 isn't implemented at all.
    
    Signed-off-by: Miek Gieben <miek@miek.nl>
    miekg authored Mar 12, 2022
    Configuration menu
    Copy the full SHA
    05140a3 View commit details
    Browse the repository at this point in the history
  2. Handle packing of empty RDATA correctly for EDNS0_EXPIRE (Resolves #1292

    ) (#1293)
    
    * Change EDNS_EXPIRE field to support zero length option data (Resolves #1292)
    
    As per [RFC7134](https://datatracker.ietf.org/doc/html/rfc7314#section-2) the Expire
    Option in queries should be zero-length. In the current implementation the field is
    uint32 which always instatiates 4bytes for that field when packing to wire format.
    For that reason we change the field to []uint8 so it can support 0-length and 4-byte
    length option data.
    
    * addressed comments
    
    * addressed comments
    
    * make change backwards compatible
    
    * add comment for Empty field
    dmavrommatis authored Mar 12, 2022
    Configuration menu
    Copy the full SHA
    d48e92a View commit details
    Browse the repository at this point in the history
  3. Release 1.1.47

    miekg committed Mar 12, 2022
    Configuration menu
    Copy the full SHA
    d70eb7b View commit details
    Browse the repository at this point in the history
Loading