Merged
Conversation
…point of the sample buffer the display jumps to the end of the buffer
Owner
|
Thanks! I ran into this bug yesterday and it's really annoying. This change does break the behaviour of zooming around the centre when using the zoom slider (rather than scroll zoom), but I think that is a better situation than keeping the current bug so I'll merge this. The code around zooming & painting has become pretty fragile and messy, so ultimately it could do with a refactor or rewrite soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you try to zoom in/out after the middle point of the sample buffer the display jumps to the end of the buffer. This branch fixes that.
Observation: there is some strange behavior of updateView, it is called recursively (from updateViewRange when horizontalScrollBar()->setValue() is called). Just guarding against the recursive call does not fix the original issue and causes some other issues, so I left that in place.