Skip to content

feat(toolkit): Support multiple Ledger Stacks in toolkit-js#946

Merged
timjroberts merged 27 commits into
mainfrom
timjroberts/PM-22230-compact-version-selection
Mar 29, 2026
Merged

feat(toolkit): Support multiple Ledger Stacks in toolkit-js#946
timjroberts merged 27 commits into
mainfrom
timjroberts/PM-22230-compact-version-selection

Conversation

@timjroberts

@timjroberts timjroberts commented Mar 15, 2026

Copy link
Copy Markdown
Contributor

Overview

PM-22230
This PR converts toolkit-js into a workspace with a v7 package supporting Compact.js built against Ledger 7, and a v8 package supporting Compact.js built against Ledger 8.

When running the toolkit from the command-line, it will default to the latest ledger version (and consequently the associated version of Compact.js that supports it), but this can be overridden by applying the LEDGER_VERSION=d environment variable. For example, to use a Compact.js that is built against Ledger 7, set LEDGER_VERSION=7 in the environment.

🗹 TODO before merging

  • Ready

📌 Submission Checklist

  • Changes are backward-compatible (or flagged if breaking)
    The combination of default behaviour and an optional environment variable keeps this change fully backward compatible.
  • Pull request description explains why the change is needed
  • Self-reviewed the diff
  • I have included a change file, or skipped for this reason:
  • If the changes introduce a new feature, I have bumped the node minor version
  • Update documentation (if relevant)
  • Updated AGENTS.md if build commands, architecture, or workflows changed
  • No new todos introduced

🧪 Testing Evidence

Please describe any additional testing aside from CI:

  • Additional tests are provided (if possible)

🔱 Fork Strategy

  • Node Runtime Update
  • Node Client Update
  • Other:
  • N/A

Links

Closes PM-22230

@timjroberts timjroberts requested a review from a team as a code owner March 15, 2026 17:18
@timjroberts timjroberts changed the title feat(toolkit): Support multiple Ledger Stack in toolkit-js feat(toolkit): Support multiple Ledger Stacks in toolkit-js Mar 15, 2026
@github-actions

github-actions Bot commented Mar 15, 2026

Copy link
Copy Markdown
Contributor

kics-logo

KICS version: v2.1.19

Category Results
CRITICAL CRITICAL 0
HIGH HIGH 2
MEDIUM MEDIUM 52
LOW LOW 3
INFO INFO 64
TRACE TRACE 0
TOTAL TOTAL 121
Metric Values
Files scanned placeholder 27
Files parsed placeholder 27
Files failed to scan placeholder 0
Total executed queries placeholder 73
Queries failed to execute placeholder 0
Execution time placeholder 11

@timjroberts timjroberts marked this pull request as draft March 15, 2026 17:40
@gilescope gilescope requested a review from ozgb March 15, 2026 18:11
@timjroberts timjroberts marked this pull request as ready for review March 16, 2026 11:22
@timjroberts timjroberts force-pushed the timjroberts/PM-22230-compact-version-selection branch from a86ad09 to b109d99 Compare March 25, 2026 17:55
@timjroberts timjroberts added this pull request to the merge queue Mar 29, 2026
Merged via the queue into main with commit c708b40 Mar 29, 2026
31 checks passed
@timjroberts timjroberts deleted the timjroberts/PM-22230-compact-version-selection branch March 29, 2026 20:15
@ozgb ozgb mentioned this pull request Apr 2, 2026
14 tasks
@gilescope gilescope added this to the node-1.0.0 milestone Apr 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants