Overview

midnight-node/util/toolkit/src/toolkit_js/encoded_zswap_local_state.rs

Line 196 in da089d4

nonce: nullifier.0.0,

CoinInfo includes a nonce field and CoinNullifier is derived as Hash<(CoinInfo, ZswapCoinSecretKey)>, so nullifier != nonce. The code appears to use the nullifier where it should use the nonce.

Reported by Mirco, confirmed as a bug by Thomas Kerber.

Ticket: https://shielded.atlassian.net/browse/PM-21923

🗹 TODO before merging

• Ready

📌 Submission Checklist

• Changes are backward-compatible (or flagged if breaking)
• Pull request description explains why the change is needed
• Self-reviewed the diff
• I have included a change file, or skipped for this reason:
• If the changes introduce a new feature, I have bumped the node minor version
• Update documentation (if relevant)
• Updated AGENTS.md if build commands, architecture, or workflows changed
• No new todos introduced

🧪 Testing Evidence

Please describe any additional testing aside from CI:

• Additional tests are provided (if possible)

🔱 Fork Strategy

• Node Runtime Update
• Node Client Update
• Other:
• N/A

Links