Skip to content

Filtering gateway#894

Merged
gilescope merged 11 commits into
mainfrom
filtering-gateway
Mar 12, 2026
Merged

Filtering gateway#894
gilescope merged 11 commits into
mainfrom
filtering-gateway

Conversation

@LGLO

@LGLO LGLO commented Mar 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Overview

Adds runtime flag to enable "filtering gateway" behavior which basically doesn't let Op::Deploy and Op:Maintain to go in the TransactionPool.
Change is implemented with a custom TransactionPool wrapper.

🗹 TODO before merging

  • Ready

📌 Submission Checklist

  • Changes are backward-compatible (or flagged if breaking)
  • Pull request description explains why the change is needed
  • Self-reviewed the diff
  • I have included a change file, or skipped for this reason:
  • If the changes introduce a new feature, I have bumped the node minor version - nope, I have not
  • Update documentation (if relevant) - I have not done it
  • Updated AGENTS.md if build commands, architecture, or workflows changed
  • No new todos introduced

🧪 Testing Evidence

Please describe any additional testing aside from CI:

Was manually tested once (by SET), will need a second run.

🔱 Fork Strategy

  • Node Runtime Update
  • Node Client Update
  • Other:
  • N/A

Links

https://shielded.atlassian.net/browse/PM-22280

@LGLO LGLO requested a review from a team as a code owner March 10, 2026 08:45
@LGLO LGLO added the ci:arm64 label Mar 10, 2026
@github-actions

github-actions Bot commented Mar 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

kics-logo

KICS version: v2.1.19

Category Results
CRITICAL CRITICAL 0
HIGH HIGH 2
MEDIUM MEDIUM 52
LOW LOW 3
INFO INFO 64
TRACE TRACE 0
TOTAL TOTAL 121
Metric Values
Files scanned placeholder 27
Files parsed placeholder 27
Files failed to scan placeholder 0
Total executed queries placeholder 73
Queries failed to execute placeholder 0
Execution time placeholder 11

gilescope
gilescope reviewed Mar 10, 2026
View reviewed changes
Comment thread node/src/filtering_pool.rs
@LGLO LGLO force-pushed the filtering-gateway branch from e504860 to cfc36ee Compare March 11, 2026 16:13
Klapeyron
Klapeyron reviewed Mar 11, 2026
View reviewed changes
Comment thread node/Cargo.toml Outdated
Klapeyron
Klapeyron reviewed Mar 11, 2026
View reviewed changes
Comment thread changes/added/filter-deploy-txs-switch.md Outdated
@NachoPal

NachoPal commented Mar 11, 2026

Copy link
Copy Markdown
Contributor

We have already a substrate built-in CallFilter in place: https://github.com/midnightntwrk/midnight-node/blob/main/runtime/src/check_call_filter.rs#L27

In case you considered it can be integrated there instead.

LGLO and others added 2 commits March 11, 2026 19:11
@LGLO @Klapeyron
Apply suggestions from code review
80b70e9 
Co-authored-by: Klapeyron <11329616+Klapeyron@users.noreply.github.com>
Remove unused dependency
5709a83
NachoPal
NachoPal reviewed Mar 11, 2026
View reviewed changes
Comment thread node/src/filtering_pool.rs
Comment thread node/src/filtering_pool.rs
Comment thread node/src/filtering_pool.rs
@gilescope gilescope enabled auto-merge March 11, 2026 20:40
@NachoPal NachoPal mentioned this pull request Mar 11, 2026
Merged
14 tasks
@gilescope gilescope mentioned this pull request Mar 11, 2026
Merged
@gilescope gilescope added this pull request to the merge queue Mar 12, 2026
Merged via the queue into main with commit 0fb234a Mar 12, 2026
34 checks passed
@gilescope gilescope deleted the filtering-gateway branch March 12, 2026 16:14
@Klapeyron Klapeyron mentioned this pull request Mar 19, 2026
Open
14 tasks
@NachoPal NachoPal mentioned this pull request Apr 10, 2026
Merged
14 tasks
@ozgb ozgb mentioned this pull request Apr 10, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gilescope gilescope gilescope approved these changes

@Klapeyron Klapeyron Klapeyron left review comments

+1 more reviewer

@NachoPal NachoPal NachoPal left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ci:arm64 release:node-0.22.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@LGLO @NachoPal @gilescope @Klapeyron