Skip to content

fix: sync issue against 0.21.0#852

Merged
gilescope merged 2 commits into
mainfrom
ozgb-fix-sync-with-0.21.0
Mar 3, 2026
Merged

fix: sync issue against 0.21.0#852
gilescope merged 2 commits into
mainfrom
ozgb-fix-sync-with-0.21.0

Conversation

@ozgb

@ozgb ozgb commented Mar 3, 2026

Copy link
Copy Markdown
Contributor

Overview

Resolves https://shielded.atlassian.net/browse/PM-22123, introduced by https://github.com/midnightntwrk/midnight-node/pull/678/changes#diff-9177d4e6acc2ada77d16c093600cd24ef8057ecfc617da949c8e96b2ffd2c77eR145-R147

Need to confirm the original reason for this change, and if we still need it

  • Confirmed, we can remove it - this was introduced to get past the first block on preview

Building image here: https://github.com/midnightntwrk/midnight-node/actions/runs/22629120930

🗹 TODO before merging

  • Ready

📌 Submission Checklist

  • Changes are backward-compatible (or flagged if breaking)
  • Pull request description explains why the change is needed
  • Self-reviewed the diff
  • I have included a change file, or skipped for this reason:
  • If the changes introduce a new feature, I have bumped the node minor version
  • Update documentation (if relevant)
  • Updated AGENTS.md if build commands, architecture, or workflows changed
  • No new todos introduced

🧪 Testing Evidence

Please describe any additional testing aside from CI:

  • Additional tests are provided (if possible)

🔱 Fork Strategy

  • Node Runtime Update
  • Node Client Update
  • Other:
  • N/A

Links

@ozgb ozgb requested a review from a team as a code owner March 3, 2026 15:04
@github-actions

github-actions Bot commented Mar 3, 2026

Copy link
Copy Markdown
Contributor

kics-logo

KICS version: v2.1.19

Category Results
CRITICAL CRITICAL 0
HIGH HIGH 0
MEDIUM MEDIUM 47
LOW LOW 3
INFO INFO 59
TRACE TRACE 0
TOTAL TOTAL 109
Metric Values
Files scanned placeholder 27
Files parsed placeholder 27
Files failed to scan placeholder 0
Total executed queries placeholder 73
Queries failed to execute placeholder 0
Execution time placeholder 11

@gilescope gilescope left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting that Oscar! Much appreciated.

@gilescope gilescope added this pull request to the merge queue Mar 3, 2026
Merged via the queue into main with commit d495725 Mar 3, 2026
80 of 85 checks passed
@gilescope gilescope deleted the ozgb-fix-sync-with-0.21.0 branch March 3, 2026 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants