Skip to content

Pc 1.8#79

Merged
gilescope merged 30 commits into
mainfrom
pc-1.8
Oct 26, 2025
Merged

Pc 1.8#79
gilescope merged 30 commits into
mainfrom
pc-1.8

Conversation

@SupernaviX

@SupernaviX SupernaviX commented Oct 2, 2025 •
edited by justinfrevert
Loading

Copy link
Copy Markdown
Contributor

📝 Description

Fork of midnight-node which updates to partnerchains 1.8.

🗹 TODO before merging

  • Ready

📌 Checklist

  • I have included a change file, or skipped for this reason:
  • Changes are backward-compatible (or flagged if breaking)
  • If the changes introduce a new feature, I have bumped the node minor version
  • I have performed a self-review of my code
  • I have updated doc strings and comments where necessary

🧪 Testing Evidence

  • Manual testing (describe scenarios)
  • Unit tests added
  • Integration tests added
  • Other (please specify):

https://shielded.atlassian.net/browse/PM-18468

@github-actions

github-actions Bot commented Oct 2, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Logo
Checkmarx One – Scan Summary & Details – 3efd8089-f6ed-446c-8615-6e9c460cb52d

Great job! No new security vulnerabilities introduced in this pull request

@justinfrevert

justinfrevert commented Oct 15, 2025

Copy link
Copy Markdown
Contributor

We had some todos for this PC integration e.g.

midnight-node/primitives/mainchain-follower/src/db/types.rs

Line 57 in a0b826b

// TODO: this is necessary boilerplate until after pc 1.6 when the dbsync-sqlx crate can be pointed to with general db types.
,

midnight-node/node/src/main_chain_follower.rs

Line 108 in a0b826b

// Note: temporary fix until after PC 1.6.1

(found by searching pc 1.6). Do you think we can take care of these here?

@SupernaviX

SupernaviX commented Oct 16, 2025

Copy link
Copy Markdown
Contributor Author

We had some todos for this PC integration e.g.

midnight-node/primitives/mainchain-follower/src/db/types.rs

Line 57 in a0b826b

// TODO: this is necessary boilerplate until after pc 1.6 when the dbsync-sqlx crate can be pointed to with general db types.

,

midnight-node/node/src/main_chain_follower.rs

Line 108 in a0b826b

// Note: temporary fix until after PC 1.6.1

(found by searching pc 1.6). Do you think we can take care of these here?

dealt with em

@justinfrevert justinfrevert marked this pull request as ready for review October 22, 2025 17:07
@justinfrevert justinfrevert requested a review from a team as a code owner October 22, 2025 17:07
gilescope
gilescope reviewed Oct 23, 2025
View reviewed changes
Comment thread node/src/cli.rs Outdated
gilescope
gilescope reviewed Oct 23, 2025
View reviewed changes
Comment thread node/src/inherent_data.rs Outdated
gilescope
gilescope reviewed Oct 23, 2025
View reviewed changes
Comment thread node/src/inherent_data.rs Outdated
gilescope
gilescope reviewed Oct 23, 2025
View reviewed changes
Comment thread node/src/main_chain_follower.rs
gilescope
gilescope reviewed Oct 23, 2025
View reviewed changes
Comment thread runtime/Cargo.toml
gilescope
gilescope reviewed Oct 23, 2025
View reviewed changes
Comment thread runtime/src/lib.rs
gilescope
gilescope reviewed Oct 23, 2025
View reviewed changes
Comment thread runtime/src/mock.rs
gilescope
gilescope requested changes Oct 23, 2025
View reviewed changes

@gilescope gilescope left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do need to sort out that chainspec part

@gilescope gilescope merged commit 5b87c80 into main Oct 26, 2025
24 checks passed
@gilescope gilescope deleted the pc-1.8 branch October 26, 2025 14:02
@ozgb ozgb mentioned this pull request Oct 29, 2025
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinfrevert justinfrevert justinfrevert left review comments

@gilescope gilescope gilescope approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SupernaviX @justinfrevert @gilescope @b-yap