Skip to content

fix: remove call to unoptimised gc#750

Merged
gilescope merged 2 commits into
mainfrom
ozgb-remove-gc
Feb 23, 2026
Merged

fix: remove call to unoptimised gc#750
gilescope merged 2 commits into
mainfrom
ozgb-remove-gc

Conversation

@ozgb

@ozgb ozgb commented Feb 23, 2026

Copy link
Copy Markdown
Contributor

Overview

We were calling the Ledger storage garbage collection synchronously at the end of each block. After running some benchmarks, we've found that it's in need of optimisation. Removing for now.

Possible cause for: https://shielded.atlassian.net/browse/PM-21969

🗹 TODO before merging

  • Ready

📌 Submission Checklist

  • Changes are backward-compatible (or flagged if breaking)
  • Pull request description explains why the change is needed
  • Self-reviewed the diff
  • I have included a change file, or skipped for this reason:
  • If the changes introduce a new feature, I have bumped the node minor version
  • Update documentation (if relevant)
  • Updated AGENTS.md if build commands, architecture, or workflows changed
  • No new todos introduced

🧪 Testing Evidence

Please describe any additional testing aside from CI:

  • Additional tests are provided (if possible)

🔱 Fork Strategy

  • Node Runtime Update
  • Node Client Update
  • Other:
  • N/A

Links

@ozgb ozgb requested a review from a team as a code owner February 23, 2026 11:09
@github-actions

github-actions Bot commented Feb 23, 2026

Copy link
Copy Markdown
Contributor

kics-logo

KICS version: v2.1.16

Category Results
CRITICAL CRITICAL 0
HIGH HIGH 0
MEDIUM MEDIUM 96
LOW LOW 12
INFO INFO 83
TRACE TRACE 0
TOTAL TOTAL 191
Metric Values
Files scanned placeholder 31
Files parsed placeholder 31
Files failed to scan placeholder 0
Total executed queries placeholder 73
Queries failed to execute placeholder 0
Execution time placeholder 9

@gilescope gilescope enabled auto-merge February 23, 2026 11:39
@gilescope gilescope added this pull request to the merge queue Feb 23, 2026
Merged via the queue into main with commit bd72c4b Feb 23, 2026
35 of 36 checks passed
@gilescope gilescope deleted the ozgb-remove-gc branch February 23, 2026 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants