chore: update toolkit to Compact 0.31.0#1555
Conversation
Bumps COMPACTC_VERSION from 0.30.0 to 0.31.0 so the toolkit pulls the latest compactc release, enabling QA to test against Compact 0.31.0. Closes #1535 Signed-off-by: Oscar Bailey <79094698+ozgb@users.noreply.github.com>
Signed-off-by: Oscar Bailey <79094698+ozgb@users.noreply.github.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9a8176cd9d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
The `toolkit-js` workspace previously named its sibling packages by ledger version (`v7/`, `v8/`) and dispatched on `LEDGER_VERSION`. The axis that actually varies between variants is the `@midnight-ntwrk/compact-js` line — which tracks the `compactc` compiler — and multiple `compactc` versions can target the same ledger version (e.g. `0.30.x` and `0.31.x` both target ledger 8), which the old scheme could not represent. - `v7/` → `compact-0.29/` (compact-js `2.4.3`) - `v8/` → `compact-0.30/` (compact-js `2.5.0`, reverted from in-place 2.5.1 bump) - Added `compact-0.31/` (compact-js `2.5.1`) - Env var: `COMPACTC_VERSION` (default `0.31`), replaces `LEDGER_VERSION`; accepts either `<major>.<minor>` or full `<major>.<minor>.<patch>` form. Assisted-by: Claude:claude-4.7-opus Signed-off-by: Oscar Bailey <79094698+ozgb@users.noreply.github.com>
Missed staging the in-place `name` edits when committing the directory renames. Without this, the `compact-0.29`/`compact-0.30` workspace packages still declare their old `node-toolkit-v7`/`v8` names while the root manifest already references the new ones, so `npm install` would fail to link them. Assisted-by: Claude:claude-4.7-opus Signed-off-by: Oscar Bailey <79094698+ozgb@users.noreply.github.com>
…ions Deploy.test.ts was skipped because the bare compact-js-command import resolved to whichever compact-js line npm hoisted, not the variant pinned for the active compactc version. - Extract the resolution hook from bin.ts into a shared compactc-resolver module so the CLI and tests dispatch identically. - Add a vitest setup file that installs the hook for the active COMPACTC_VERSION, so the test (and the config it loads) resolves compact-js*/compact-runtime against the matching variant. - Add scripts/test-all-compactc.sh (npm run test:compat) which recompiles the test contract and runs the suite once per supported version, since the generated managed/ output is version-specific. - Route per-version test artifacts (intent/output-ps/zswap) to ignored paths. Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Oscar Bailey <79094698+ozgb@users.noreply.github.com>
…port Assisted-By: Claude:claude-opus-4.8 Signed-off-by: Oscar Bailey <79094698+ozgb@users.noreply.github.com>
The --network flag was removed from toolkit.js in the latest version Signed-off-by: Oscar Bailey <79094698+ozgb@users.noreply.github.com>
Signed-off-by: Oscar Bailey <79094698+ozgb@users.noreply.github.com>
Signed-off-by: Oscar Bailey <79094698+ozgb@users.noreply.github.com>
Signed-off-by: Oscar Bailey <79094698+ozgb@users.noreply.github.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 41a388ae70
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Signed-off-by: Oscar Bailey <79094698+ozgb@users.noreply.github.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a5fe1641c3
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
- Run npm run build:variants in the test script to ensure dynamic resolution works - Fix variant detection in toolkit integration tests Signed-off-by: Oscar Bailey <79094698+ozgb@users.noreply.github.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9303896ffb
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Signed-off-by: Oscar Bailey <79094698+ozgb@users.noreply.github.com>
Signed-off-by: Oscar Bailey <79094698+ozgb@users.noreply.github.com>
Overview
Bumps COMPACTC_VERSION from 0.30.0 to 0.31.0 so the toolkit pulls the
latest compactc release, enabling QA to test against Compact 0.31.0.
🗹 TODO before merging
📌 Submission Checklist
git commit -s) for the DCO🧪 Testing Evidence
Please describe any additional testing aside from CI:
🔱 Fork Strategy
Links
Closes #1535