feat: add error log when D_P < n_P (#1505)#1506
Conversation
Signed-off-by: Oscar Bailey <79094698+ozgb@users.noreply.github.com>
Signed-off-by: Oscar Bailey <79094698+ozgb@users.noreply.github.com>
Signed-off-by: Oscar Bailey <79094698+ozgb@users.noreply.github.com>
gilescope
left a comment
There was a problem hiding this comment.
Bin the start up check. Its a lot of code and when starting from genesis d-param / authorities for the session are from the chainspec so I'm not sure it would be comparing the right thing. The per session error is the stonger of the two checks anyway.
|
I have a feeling that the problems could be solved by modification to selection algorithm:
Today I see this PR. Yesterday I was reviewing few pages of documentation by Jon. Selection algorithm is under our control and can solve both. |
Lots of code for little improvement over just the session change check Signed-off-by: Oscar Bailey <79094698+ozgb@users.noreply.github.com>
Agreed on this - the fact that adding a permissioned candidate impacts liveness is not intuitive Suggest we keep this error print for now - and propose a new PR with those selection changes, or alternative changes that fix the D < P liveness issues |
|
Agreed - two separate PRs seems best (that way we have a rollback path) |
Overview
Fixes #1505
🗹 TODO before merging
📌 Submission Checklist
git commit -s) for the DCO🧪 Testing Evidence
Please describe any additional testing aside from CI:
🔱 Fork Strategy
Links