Skip to content

feat: add pre-approvals filter to c2m-bridge#1477

Merged
LGLO merged 1 commit into
mainfrom
c-to-m-bridge-approvals
May 14, 2026
Merged

feat: add pre-approvals filter to c2m-bridge#1477
LGLO merged 1 commit into
mainfrom
c-to-m-bridge-approvals

Conversation

@LGLO

@LGLO LGLO commented May 8, 2026

Copy link
Copy Markdown
Contributor

Overview

For some time the protocol bridge will remain restricted by adding pre-approvals mechanism.

Each Cardano transaction should be first approved by the governance - by adding Cardano Tx Hash to Approved set.
Then it should be submitted to Cardano.

🗹 TODO before merging

  • Ready

📌 Submission Checklist

  • All commits are signed off (git commit -s) for the DCO
  • Changes are backward-compatible (or flagged if breaking)
  • Pull request description explains why the change is needed
  • Self-reviewed the diff
  • I have included a change file, or skipped for this reason:
  • If the changes introduce a new feature, I have bumped the node minor version
  • Update documentation (if relevant)
  • Updated AGENTS.md if build commands, architecture, or workflows changed
  • No new todos introduced

🧪 Testing Evidence

Please describe any additional testing aside from CI:

  • Additional tests are provided (if possible)

🔱 Fork Strategy

  • Node Runtime Update
  • Node Client Update
  • Other:
  • N/A

Links

https://github.com/shieldedtech/midnight-c-to-m-protocol-bridge/issues/2

@LGLO LGLO requested a review from a team as a code owner May 8, 2026 12:17
@LGLO LGLO force-pushed the c-to-m-bridge-approvals branch from d09925e to 5e12e55 Compare May 8, 2026 12:32
Comment thread pallets/c2m-bridge/src/lib.rs Outdated
Comment thread pallets/c2m-bridge/src/lib.rs Outdated
Comment thread pallets/c2m-bridge/src/tests.rs Outdated
Comment thread pallets/c2m-bridge/src/lib.rs Outdated
Comment thread pallets/c2m-bridge/src/lib.rs Outdated
Comment thread pallets/c2m-bridge/src/lib.rs Outdated
Comment thread pallets/c2m-bridge/src/lib.rs
Klapeyron
Klapeyron previously approved these changes May 13, 2026
@LGLO LGLO force-pushed the c-to-m-bridge-approvals branch from b6f14fb to 90f1293 Compare May 13, 2026 08:40
@LGLO LGLO added this pull request to the merge queue May 13, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 13, 2026
@LGLO LGLO added this pull request to the merge queue May 13, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 13, 2026
@LGLO LGLO enabled auto-merge May 13, 2026 14:24
@LGLO

LGLO commented May 14, 2026

Copy link
Copy Markdown
Contributor Author

/bot rebuild-metadata

@github-actions

Copy link
Copy Markdown
Contributor

✅ Metadata rebuild complete. No changes detected.

Signed-off-by: Lech Głowiak <lech.glowiak@shielded.io>
@LGLO LGLO force-pushed the c-to-m-bridge-approvals branch from 8e7797e to a2adb5c Compare May 14, 2026 11:55
@LGLO LGLO added this pull request to the merge queue May 14, 2026
Merged via the queue into main with commit e0ee2e9 May 14, 2026
35 checks passed
@LGLO LGLO deleted the c-to-m-bridge-approvals branch May 14, 2026 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants