Skip to content

feat: handling of subminimal transfers#1393

Merged
LGLO merged 16 commits into
mainfrom
c-to-m-subminimal-transfers-accumulation
May 6, 2026
Merged

feat: handling of subminimal transfers#1393
LGLO merged 16 commits into
mainfrom
c-to-m-subminimal-transfers-accumulation

Conversation

@LGLO

@LGLO LGLO commented Apr 23, 2026

Copy link
Copy Markdown
Contributor

Overview

Implements logic of subminmal transfers handling in Cardano-to-Midnight bridge pallet

🗹 TODO before merging

  • Ready

📌 Submission Checklist

  • Changes are backward-compatible (or flagged if breaking)
  • Pull request description explains why the change is needed
  • Self-reviewed the diff
  • I have included a change file, or skipped for this reason:
  • If the changes introduce a new feature, I have bumped the node minor version
  • Update documentation (if relevant)
  • Updated AGENTS.md if build commands, architecture, or workflows changed
  • No new todos introduced

🧪 Testing Evidence

Please describe any additional testing aside from CI:

  • Additional tests are provided (if possible)

🔱 Fork Strategy

  • Node Runtime Update
  • Node Client Update
  • Other:
  • N/A

Links

Signed-off-by: Lech Głowiak <lech.glowiak@shielded.io>
@LGLO LGLO requested a review from a team as a code owner April 23, 2026 10:30
@LGLO

LGLO commented Apr 23, 2026

Copy link
Copy Markdown
Contributor Author

/bot rebuild-metadata

@github-actions

Copy link
Copy Markdown
Contributor

✅ Metadata rebuild complete! Changes have been committed.

Comment thread pallets/c2m-bridge/src/tests.rs
Comment thread pallets/c2m-bridge/src/lib.rs Outdated
Comment thread pallets/c2m-bridge/src/lib.rs Outdated
Comment thread pallets/c2m-bridge/src/lib.rs Outdated
Comment thread pallets/c2m-bridge/src/lib.rs Outdated
LGLO added 3 commits April 29, 2026 09:54
Signed-off-by: Lech Głowiak <lech.glowiak@shielded.io>
Signed-off-by: Lech Głowiak <lech.glowiak@shielded.io>
Signed-off-by: Lech Głowiak <lech.glowiak@shielded.io>
@LGLO

LGLO commented May 4, 2026

Copy link
Copy Markdown
Contributor Author

/bot rebuild-metadata

@github-actions

github-actions Bot commented May 4, 2026

Copy link
Copy Markdown
Contributor

✅ Metadata rebuild complete! Changes have been committed.

Signed-off-by: Lech Głowiak <lech.glowiak@shielded.io>
@LGLO

LGLO commented May 5, 2026

Copy link
Copy Markdown
Contributor Author

/bot rebuild-metadata

@github-actions

github-actions Bot commented May 5, 2026

Copy link
Copy Markdown
Contributor

✅ Metadata rebuild complete! Changes have been committed.

Comment thread pallets/c2m-bridge/src/lib.rs Outdated
Comment thread pallets/c2m-bridge/src/lib.rs
Comment thread pallets/c2m-bridge/src/mock.rs Outdated
Comment thread pallets/c2m-bridge/src/lib.rs Outdated
Comment thread pallets/c2m-bridge/src/lib.rs Outdated
LGLO and others added 3 commits May 5, 2026 14:12
@LGLO

LGLO commented May 5, 2026

Copy link
Copy Markdown
Contributor Author

/bot rebuild-metadata

@github-actions

github-actions Bot commented May 5, 2026

Copy link
Copy Markdown
Contributor

✅ Metadata rebuild complete! Changes have been committed.

@cosmir17 cosmir17 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Posting line comments and nits as a non-blocking review. @Klapeyron has the merge call as code owner.

Comment thread pallets/c2m-bridge/src/lib.rs Outdated
Comment thread pallets/c2m-bridge/src/lib.rs Outdated
Comment thread pallets/c2m-bridge/src/lib.rs
Comment thread pallets/c2m-bridge/src/lib.rs Outdated
Comment thread pallets/c2m-bridge/src/lib.rs Outdated
Comment thread pallets/c2m-bridge/src/lib.rs Outdated
Comment thread pallets/c2m-bridge/src/lib.rs Outdated
Comment thread pallets/c2m-bridge/src/lib.rs
@cosmir17

cosmir17 commented May 5, 2026

Copy link
Copy Markdown
Contributor

closing and re-opening PR as ci is not running.

@cosmir17 cosmir17 closed this May 5, 2026
@cosmir17 cosmir17 reopened this May 5, 2026
Signed-off-by: Lech Głowiak <lech.glowiak@shielded.io>
@LGLO

LGLO commented May 6, 2026

Copy link
Copy Markdown
Contributor Author

/bot rebuild-metadata

@github-actions

github-actions Bot commented May 6, 2026

Copy link
Copy Markdown
Contributor

❌ Metadata rebuild failed. Check the workflow logs for details.

LGLO added 2 commits May 6, 2026 08:29
Signed-off-by: Lech Głowiak <lech.glowiak@shielded.io>
Signed-off-by: Lech Głowiak <lech.glowiak@shielded.io>
@LGLO LGLO requested a review from Klapeyron May 6, 2026 07:46
Comment thread pallets/c2m-bridge/src/lib.rs Outdated
Signed-off-by: Lech Głowiak <lech.glowiak@shielded.io>
@LGLO LGLO enabled auto-merge May 6, 2026 10:13
@LGLO LGLO added this pull request to the merge queue May 6, 2026
Merged via the queue into main with commit 19f8b0f May 6, 2026
34 checks passed
@LGLO LGLO deleted the c-to-m-subminimal-transfers-accumulation branch May 6, 2026 11:03
@cosmir17

cosmir17 commented May 6, 2026

Copy link
Copy Markdown
Contributor

As Klapeyron approved, I too approve this PR 🙏 Thanks for your work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[C-to-M Bridge] Accumulate too small transactions

3 participants