Skip to content

bump node for 0.22.5 fix#1251

Merged
justinfrevert merged 3 commits into
release/node-0.22.5from
bump-node-0.22.5-fix-gas-cli
Apr 7, 2026
Merged

bump node for 0.22.5 fix#1251
justinfrevert merged 3 commits into
release/node-0.22.5from
bump-node-0.22.5-fix-gas-cli

Conversation

@justinfrevert

@justinfrevert justinfrevert commented Apr 7, 2026 •
edited by gilescope
Loading

Copy link
Copy Markdown
Contributor

Overview

Bumps the node version from 0.22.2 to 0.22.5 and adds support for configuring max_tx_gas_cost via the MAX_TX_GAS_COST env var (in addition to the existing --max-tx-gas-cost CLI arg). The CLI arg takes precedence over the env var when both are set.

Changes:

  • node/Cargo.toml / Cargo.lock: version bump 0.22.2 → 0.22.5
  • node/src/cfg/midnight_cfg/mod.rs: add max_tx_gas_cost: Option<u64> to MidnightCfg (env var source)
  • node/src/command.rs: merge CLI arg and env var with CLI precedence via .or()
  • changes/added/max-tx-gas-cost-filter.md: change file

🗹 TODO before merging

  • Ready

📌 Submission Checklist

  • Changes are backward-compatible (or flagged if breaking)
  • Pull request description explains why the change is needed
  • Self-reviewed the diff
  • I have included a change file, or skipped for this reason:
  • If the changes introduce a new feature, I have bumped the node minor version
  • Update documentation (if relevant)
  • Updated AGENTS.md if build commands, architecture, or workflows changed
  • No new todos introduced

🧪 Testing Evidence

Deployed to devnet via shieldedtech/shielded-gitops#1758.

  • Additional tests are provided (if possible)

🔱 Fork Strategy

  • Node Runtime Update
  • Node Client Update
  • Other:
  • N/A

Links

@justinfrevert justinfrevert requested a review from a team as a code owner April 7, 2026 18:57
mpskowron
mpskowron approved these changes Apr 7, 2026
View reviewed changes

@mpskowron mpskowron left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that in previous commit where you added filtering you let transactions which cost cannot be calculated to pass through, why is that?

@justinfrevert

justinfrevert commented Apr 7, 2026

Copy link
Copy Markdown
Contributor Author

I see that in previous commit where you added filtering you let transactions which cost cannot be calculated to pass through, why is that?

It's not guaranteed that the failure is due to the tx size, or even an issue with that specific transaction. The transaction at that point should be validated by the rest of the system.

@justinfrevert justinfrevert merged commit 9d8a28c into release/node-0.22.5 Apr 7, 2026
38 of 39 checks passed
@justinfrevert justinfrevert deleted the bump-node-0.22.5-fix-gas-cli branch April 7, 2026 19:59
@chrispalaskas

chrispalaskas commented Apr 13, 2026

Copy link
Copy Markdown
Contributor

Test results:
✅ When 1/4 applied smaller txs than 25% made it into the blocks
Screenshot from 2026-04-13 12-35-21
✅  When 1/4 applied larger txs than 25% did not make it into blocks:
⚠️  Failed to register seed 100, retrying (3/10)...
✅  When full value applied larger txs than 25% DID make it into blocks:
image

The only notable thing was that if the RPC node did not have the filter, they would hold the tx in their mempool until it timed out, and the moment the filters were removed the tx would make it into the block. I suggest we keep the filter on gateways and RPC nodes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mpskowron mpskowron mpskowron approved these changes

Assignees

No one assigned

Labels

skip-changes-check-jira

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@justinfrevert @chrispalaskas @mpskowron