Skip to content

fix(throttle): add transaction count limit, reduce window to 1hr#1060

Merged
ozgb merged 5 commits into
mainfrom
ozgb-throttle-enhancement
Mar 24, 2026
Merged

fix(throttle): add transaction count limit, reduce window to 1hr#1060
ozgb merged 5 commits into
mainfrom
ozgb-throttle-enhancement

Conversation

@ozgb

@ozgb ozgb commented Mar 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Overview

Resolves https://shielded.atlassian.net/browse/PM-22377

Transactions with small size but proportionally high weight allowed members of the governance committee to fill blocks. This PR adds an absolute transaction count limit, closing this issue.

After fix:

2026-03-23 17:11:21        RPC-CORE: submitExtrinsic(extrinsic: Extrinsic): Hash:: 1010: Invalid Transaction: Transaction would exhaust the block limits

🗹 TODO before merging

  • Ready

📌 Submission Checklist

  • Changes are backward-compatible (or flagged if breaking)
  • Pull request description explains why the change is needed
  • Self-reviewed the diff
  • I have included a change file, or skipped for this reason:
  • If the changes introduce a new feature, I have bumped the node minor version
  • Update documentation (if relevant)
  • Updated AGENTS.md if build commands, architecture, or workflows changed
  • No new todos introduced

🧪 Testing Evidence

Please describe any additional testing aside from CI:

  • Additional tests are provided (if possible)

🔱 Fork Strategy

  • Node Runtime Update
  • Node Client Update
  • Other:
  • N/A

Links

ozgb added 2 commits March 23, 2026 17:08
@ozgb
feat(throttle): add per-account transaction count limit and storage m…
ae8a795 
…igration

Track txs_used alongside bytes_used in AccountUsage storage, enforcing
a MaxTxs limit per rolling window. Migrates storage from the old 2-field
tuple to the new UsageStats struct by clearing the map (v0 → v1).
@ozgb
test(throttle): add tests for per-account transaction count limit
a54cd6d
@ozgb ozgb requested a review from a team as a code owner March 23, 2026 17:14
@github-actions

github-actions Bot commented Mar 23, 2026

Copy link
Copy Markdown
Contributor

kics-logo

KICS version: v2.1.19

Category Results
CRITICAL CRITICAL 0
HIGH HIGH 2
MEDIUM MEDIUM 53
LOW LOW 3
INFO INFO 64
TRACE TRACE 0
TOTAL TOTAL 122
Metric Values
Files scanned placeholder 28
Files parsed placeholder 28
Files failed to scan placeholder 0
Total executed queries placeholder 647
Queries failed to execute placeholder 0
Execution time placeholder 18

@justinfrevert

justinfrevert commented Mar 23, 2026

Copy link
Copy Markdown
Contributor

/bot rebuild-metadata

@justinfrevert justinfrevert enabled auto-merge March 23, 2026 20:35
@github-actions

github-actions Bot commented Mar 23, 2026

Copy link
Copy Markdown
Contributor

✅ Metadata rebuild complete! Changes have been committed.

@ozgb ozgb closed this Mar 24, 2026
auto-merge was automatically disabled March 24, 2026 08:40

Pull request was closed

@ozgb ozgb reopened this Mar 24, 2026
@ozgb ozgb added this pull request to the merge queue Mar 24, 2026
Merged via the queue into main with commit f2c2760 Mar 24, 2026
32 checks passed
@ozgb ozgb deleted the ozgb-throttle-enhancement branch March 24, 2026 16:16
@gilescope gilescope added this to the node-1.0.0 milestone Apr 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinfrevert justinfrevert justinfrevert approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

node-1.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@ozgb @justinfrevert @gilescope @TheNewAutonomy