Skip to content

fix: restrict peer rpc methods#1027

Merged
justinfrevert merged 2 commits into
mainfrom
fix/mark-peer-rpcs-unsafe
Mar 19, 2026
Merged

fix: restrict peer rpc methods#1027
justinfrevert merged 2 commits into
mainfrom
fix/mark-peer-rpcs-unsafe

Conversation

@justinfrevert

@justinfrevert justinfrevert commented Mar 18, 2026

Copy link
Copy Markdown
Contributor

Overview

Ensure that rpc methods that can reveal network information are marked unsafe.

🗹 TODO before merging

  • Ready

📌 Submission Checklist

  • Changes are backward-compatible (or flagged if breaking)
  • Pull request description explains why the change is needed
  • Self-reviewed the diff
  • I have included a change file, or skipped for this reason:
  • If the changes introduce a new feature, I have bumped the node minor version
  • Update documentation (if relevant)
  • Updated AGENTS.md if build commands, architecture, or workflows changed
  • No new todos introduced

🧪 Testing Evidence

Please describe any additional testing aside from CI:

  • Additional tests are provided (if possible)

🔱 Fork Strategy

  • Node Runtime Update
  • Node Client Update
  • Other:
  • N/A

Links

@justinfrevert justinfrevert requested a review from a team as a code owner March 18, 2026 20:55
@github-actions

Copy link
Copy Markdown
Contributor

kics-logo

KICS version: v2.1.19

Category Results
CRITICAL CRITICAL 0
HIGH HIGH 2
MEDIUM MEDIUM 52
LOW LOW 3
INFO INFO 64
TRACE TRACE 0
TOTAL TOTAL 121
Metric Values
Files scanned placeholder 27
Files parsed placeholder 27
Files failed to scan placeholder 0
Total executed queries placeholder 73
Queries failed to execute placeholder 0
Execution time placeholder 11

@gilescope gilescope changed the title fix: mark peer rpc methods unsafe fix: restrict peer rpc methods Mar 18, 2026
@gilescope gilescope added this pull request to the merge queue Mar 18, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 19, 2026
@justinfrevert justinfrevert added this pull request to the merge queue Mar 19, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 19, 2026
@justinfrevert justinfrevert added this pull request to the merge queue Mar 19, 2026
Merged via the queue into main with commit 215ee82 Mar 19, 2026
35 of 36 checks passed
@justinfrevert justinfrevert deleted the fix/mark-peer-rpcs-unsafe branch March 19, 2026 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants