Skip to content

fix: remove heavyweight hardfork machinery#1024

Merged
gilescope merged 4 commits into
mainfrom
giles-remove-hardfork-test-versions
Mar 18, 2026
Merged

fix: remove heavyweight hardfork machinery#1024
gilescope merged 4 commits into
mainfrom
giles-remove-hardfork-test-versions

Conversation

@gilescope

@gilescope gilescope commented Mar 18, 2026

Copy link
Copy Markdown
Contributor

Overview

Remove the *-hf ledger dependencies (from the hard-fork-test-ledger-8.0.0 tag) and all
cfg(hardfork_test) / cfg(hardfork_test_rollback) conditional compilation infrastructure.
Hard-fork e2e tests no longer require building a separate node with an older ledger version.

What was removed:

  • 10 workspace *-hf crate dependencies from root Cargo.toml
  • hard_fork_test module from ledger and ledger/helpers crates
  • ledger/src/host_api/ledger_hf.rs (entire file)
  • LedgerBridgeHf host functions from node service
  • HARDFORK_TEST / HARDFORK_TEST_ROLLBACK env var handling in build scripts
  • cfg(hardfork_test) branches in runtime VERSION, pallet STORAGE_VERSION, and helper utils
  • hardfork_test_rollback runtime VERSION variant

🗹 TODO before merging

  • Ready

📌 Submission Checklist

  • Changes are backward-compatible (or flagged if breaking)
  • Pull request description explains why the change is needed
  • Self-reviewed the diff
  • I have included a change file, or skipped for this reason:
  • If the changes introduce a new feature, I have bumped the node minor version
  • Update documentation (if relevant)
  • Updated AGENTS.md if build commands, architecture, or workflows changed
  • No new todos introduced

🧪 Testing Evidence

cargo clippy -p midnight-node-ledger -p midnight-node-ledger-helpers -p pallet-midnight passes.

  • Additional tests are provided (if possible)

🔱 Fork Strategy

  • Node Runtime Update
  • Node Client Update
  • Other:
  • N/A

Links

Signed-off-by: Giles Cope <gilescope@gmail.com>
@github-actions

Copy link
Copy Markdown
Contributor

kics-logo

KICS version: v2.1.19

Category Results
CRITICAL CRITICAL 0
HIGH HIGH 2
MEDIUM MEDIUM 52
LOW LOW 3
INFO INFO 64
TRACE TRACE 0
TOTAL TOTAL 121
Metric Values
Files scanned placeholder 27
Files parsed placeholder 27
Files failed to scan placeholder 0
Total executed queries placeholder 73
Queries failed to execute placeholder 0
Execution time placeholder 11

Signed-off-by: Giles Cope <gilescope@gmail.com>
@gilescope gilescope marked this pull request as ready for review March 18, 2026 08:46
@gilescope gilescope requested a review from a team as a code owner March 18, 2026 08:46
@gilescope gilescope enabled auto-merge March 18, 2026 10:36

@NachoPal NachoPal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that hardfork-e2e.sh file should be removed also?

@gilescope gilescope added this pull request to the merge queue Mar 18, 2026
@gilescope

Copy link
Copy Markdown
Contributor Author

will remove that in a follow up

Merged via the queue into main with commit 803709a Mar 18, 2026
32 checks passed
@gilescope gilescope deleted the giles-remove-hardfork-test-versions branch March 18, 2026 14:36
@NachoPal NachoPal mentioned this pull request Mar 18, 2026
14 tasks
@NachoPal

NachoPal commented Mar 18, 2026

Copy link
Copy Markdown
Contributor

will remove that in a follow up

#1026

@gilescope gilescope added this to the node-1.0.0 milestone Apr 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove hard-fork test ledger version dependencies

2 participants