fix: remove heavyweight hardfork machinery#1024
Merged
Merged
Conversation
Signed-off-by: Giles Cope <gilescope@gmail.com>
Contributor
Signed-off-by: Giles Cope <gilescope@gmail.com>
NachoPal
approved these changes
Mar 18, 2026
NachoPal
left a comment
Contributor
There was a problem hiding this comment.
I understand that hardfork-e2e.sh file should be removed also?
Contributor
Author
|
will remove that in a follow up |
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Overview
Remove the
*-hfledger dependencies (from thehard-fork-test-ledger-8.0.0tag) and allcfg(hardfork_test)/cfg(hardfork_test_rollback)conditional compilation infrastructure.Hard-fork e2e tests no longer require building a separate node with an older ledger version.
What was removed:
*-hfcrate dependencies from rootCargo.tomlhard_fork_testmodule fromledgerandledger/helperscratesledger/src/host_api/ledger_hf.rs(entire file)LedgerBridgeHfhost functions from node serviceHARDFORK_TEST/HARDFORK_TEST_ROLLBACKenv var handling in build scriptscfg(hardfork_test)branches in runtime VERSION, pallet STORAGE_VERSION, and helper utilshardfork_test_rollbackruntime VERSION variant🗹 TODO before merging
📌 Submission Checklist
🧪 Testing Evidence
cargo clippy -p midnight-node-ledger -p midnight-node-ledger-helpers -p pallet-midnightpasses.🔱 Fork Strategy
Links