Merged
Conversation
Owner
|
I've made some changes to the code, please test pause feature with external and internal sync. use uClock.pause() for pause and unpause. If everything went well i can merge the PR. |
…instead start internal clock at SYNCING state
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #49, implements ability to pause + continue on internal clock.
Not sure how this will affect external clocks -- probably won't work well, may need some thought..
Also added user callbacks via setOnClockPause and setOnClockContinue for when paused and continued, although haven't tested these.
Mostly submitting this as a pull request in hopes it will find its way into main branch sooner, since things in my development environment are getting messy now that I have multiple branches for new features (like #41) that my own libraries are starting to rely on😅