Skip to content

Fallback to a hardware-agnostic "Generic mode" on unsupported boards, or as a compile-time option#35

Merged
midilab merged 9 commits intomidilab:mainfrom
doctea:software-version
Nov 16, 2024
Merged

Fallback to a hardware-agnostic "Generic mode" on unsupported boards, or as a compile-time option#35
midilab merged 9 commits intomidilab:mainfrom
doctea:software-version

Conversation

@doctea
Copy link
Contributor

@doctea doctea commented Mar 26, 2024

No description provided.

@midilab
Copy link
Owner

midilab commented Sep 12, 2024

Hey @doctea ,

Thank you for this other contribution! i will review asap and get back to you.

@midilab
Copy link
Owner

midilab commented Nov 3, 2024

Hi @doctea ,

I have review your code and everything looks great! i just have some suggestions for better library usage from user perspective.

uClock.run() to avoid forward declarations and micros call, and change generic to software timer, so it is more explicit on platforms folder that it is a software implementation and also the USE_UCLOCK_SOFTWARE_TIMER to force the labeling that it is a software implementation.

Please feel free to check and discuss anything about the changes.

Do you have any example to add to examples folder? it helps a lot the library users to start from something and see from their selfs a blink timer ligth come to life. i guess the only problem with a generic implementation and a blink example could be the different kinda of blink pins, but it can be a simple define option for the user of any controller to chose based on his microcontroller model.

@midilab midilab merged commit 594d5ab into midilab:main Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants