Fallback to a hardware-agnostic "Generic mode" on unsupported boards, or as a compile-time option#35
Conversation
|
Hey @doctea , Thank you for this other contribution! i will review asap and get back to you. |
|
Hi @doctea , I have review your code and everything looks great! i just have some suggestions for better library usage from user perspective. uClock.run() to avoid forward declarations and micros call, and change generic to software timer, so it is more explicit on platforms folder that it is a software implementation and also the USE_UCLOCK_SOFTWARE_TIMER to force the labeling that it is a software implementation. Please feel free to check and discuss anything about the changes. Do you have any example to add to examples folder? it helps a lot the library users to start from something and see from their selfs a blink timer ligth come to life. i guess the only problem with a generic implementation and a blink example could be the different kinda of blink pins, but it can be a simple define option for the user of any controller to chose based on his microcontroller model. |
No description provided.