Skip to content

fix(standard-server): change SHORTABLE_ORIGIN from orpc:// to http:// for Android WebView compatibility #1295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
unnoq merged 3 commits into from
Dec 12, 2025
Merged

fix(standard-server): change SHORTABLE_ORIGIN from orpc:// to http:// for Android WebView compatibility #1295

unnoq merged 3 commits into from
Dec 12, 2025

Conversation

Copy link
Contributor

Copilot AI commented Dec 12, 2025 •
edited
Loading

  • Change SHORTABLE_ORIGIN from 'orpc://localhost' to 'http://orpc' in /packages/standard-server-peer/src/codec.ts
  • Update SHORTABLE_ORIGIN_MATCHER regex to match the new origin pattern
  • Update comment in SerializedRequestPayload interface to reflect new origin
  • Update tests in /packages/standard-server-peer/src/codec.test.ts to use the new http://orpc scheme
  • Update /packages/client/src/adapters/message-port/rpc-link.ts to use http://orpc
  • Update /packages/client/src/adapters/websocket/rpc-link.ts to use http://orpc
  • Update all related test files to use http://orpc:
    • /packages/client/src/adapters/message-port/rpc-link.test.ts
    • /packages/client/src/adapters/websocket/rpc-link.test.ts
    • /packages/server/src/adapters/websocket/rpc-handler.test.ts
    • /packages/server/src/adapters/crossws/rpc-handler.test.ts
    • /packages/server/src/adapters/bun-ws/rpc-handler.test.ts
    • /packages/server/src/adapters/message-port/rpc-handler.test.ts
    • /packages/server/src/adapters/ws/rpc-handler.test.ts
  • Run tests to verify changes work correctly (all 4631 tests passed)
  • Run code review (no issues found)
  • Run security checks (no vulnerabilities found)
Original prompt

On codec.ts, Please change SHORTABLE_ORIGIN to http://orpc becaues currently orpc:// schema is not allowed in adroid webview - please fix it and update according tests

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

@coderabbitai
Copy link

coderabbitai bot commented Dec 12, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Comment @coderabbitai help to get the list of available commands and usage tips.

@unnoq
fix: change SHORTABLE_ORIGIN from orpc:// to http://orpc for Android …
f0a3283 
…WebView compatibility

Co-authored-by: unnoq <64189902+unnoq@users.noreply.github.com>
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Dec 12, 2025 •
edited
Loading

Deploying orpc with  Cloudflare Pages  Cloudflare Pages

Latest commit: a21406b
Status: ✅  Deploy successful!
Preview URL: https://76578154.orpc-1qh.pages.dev
Branch Preview URL: https://copilot-fix-shortable-origin.orpc-1qh.pages.dev

View logs

@unnoq
Copy link
Member

unnoq commented Dec 12, 2025

@copilot don't forget update in packages/client/src/adapters/message-port/rpc-link.ts

Copilot AI changed the title [WIP] Fix shortable origin to use http schema fix: change SHORTABLE_ORIGIN from orpc:// to http://orpc for Android WebView compatibility Dec 12, 2025
Copilot AI requested a review from unnoq December 12, 2025 14:50
@unnoq
fix: update orpc://localhost to http://orpc in client adapters and tests
a21406b 
Co-authored-by: unnoq <64189902+unnoq@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Dec 12, 2025

@copilot don't forget update in packages/client/src/adapters/message-port/rpc-link.ts

Updated in commit a21406b. Also updated the websocket adapter and all related test files.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 12, 2025
@unnoq unnoq changed the title fix: change SHORTABLE_ORIGIN from orpc:// to http://orpc for Android WebView compatibility fix(standard-server): change SHORTABLE_ORIGIN from orpc:// to http:// for Android WebView compatibility Dec 12, 2025
Copilot AI requested a review from unnoq December 12, 2025 14:59
@unnoq unnoq marked this pull request as ready for review December 12, 2025 14:59
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Dec 12, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 12, 2025 •
edited
Loading

More templates

@orpc/ai-sdk

npm i https://pkg.pr.new/@orpc/ai-sdk@1295

@orpc/arktype

npm i https://pkg.pr.new/@orpc/arktype@1295

@orpc/client

npm i https://pkg.pr.new/@orpc/client@1295

@orpc/contract

npm i https://pkg.pr.new/@orpc/contract@1295

@orpc/experimental-durable-iterator

npm i https://pkg.pr.new/@orpc/experimental-durable-iterator@1295

@orpc/hey-api

npm i https://pkg.pr.new/@orpc/hey-api@1295

@orpc/interop

npm i https://pkg.pr.new/@orpc/interop@1295

@orpc/json-schema

npm i https://pkg.pr.new/@orpc/json-schema@1295

@orpc/nest

npm i https://pkg.pr.new/@orpc/nest@1295

@orpc/openapi

npm i https://pkg.pr.new/@orpc/openapi@1295

@orpc/openapi-client

npm i https://pkg.pr.new/@orpc/openapi-client@1295

@orpc/otel

npm i https://pkg.pr.new/@orpc/otel@1295

@orpc/experimental-pino

npm i https://pkg.pr.new/@orpc/experimental-pino@1295

@orpc/experimental-publisher

npm i https://pkg.pr.new/@orpc/experimental-publisher@1295

@orpc/experimental-publisher-durable-object

npm i https://pkg.pr.new/@orpc/experimental-publisher-durable-object@1295

@orpc/experimental-ratelimit

npm i https://pkg.pr.new/@orpc/experimental-ratelimit@1295

@orpc/react

npm i https://pkg.pr.new/@orpc/react@1295

@orpc/react-query

npm i https://pkg.pr.new/@orpc/react-query@1295

@orpc/experimental-react-swr

npm i https://pkg.pr.new/@orpc/experimental-react-swr@1295

@orpc/server

npm i https://pkg.pr.new/@orpc/server@1295

@orpc/shared

npm i https://pkg.pr.new/@orpc/shared@1295

@orpc/solid-query

npm i https://pkg.pr.new/@orpc/solid-query@1295

@orpc/standard-server

npm i https://pkg.pr.new/@orpc/standard-server@1295

@orpc/standard-server-aws-lambda

npm i https://pkg.pr.new/@orpc/standard-server-aws-lambda@1295

@orpc/standard-server-fastify

npm i https://pkg.pr.new/@orpc/standard-server-fastify@1295

@orpc/standard-server-fetch

npm i https://pkg.pr.new/@orpc/standard-server-fetch@1295

@orpc/standard-server-node

npm i https://pkg.pr.new/@orpc/standard-server-node@1295

@orpc/standard-server-peer

npm i https://pkg.pr.new/@orpc/standard-server-peer@1295

@orpc/svelte-query

npm i https://pkg.pr.new/@orpc/svelte-query@1295

@orpc/tanstack-query

npm i https://pkg.pr.new/@orpc/tanstack-query@1295

@orpc/trpc

npm i https://pkg.pr.new/@orpc/trpc@1295

@orpc/valibot

npm i https://pkg.pr.new/@orpc/valibot@1295

@orpc/vue-colada

npm i https://pkg.pr.new/@orpc/vue-colada@1295

@orpc/vue-query

npm i https://pkg.pr.new/@orpc/vue-query@1295

@orpc/zod

npm i https://pkg.pr.new/@orpc/zod@1295

commit: a21406b

@unnoq unnoq merged commit d12598b into main Dec 12, 2025
12 checks passed
@codecov
Copy link

codecov bot commented Dec 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@unnoq unnoq Awaiting requested review from unnoq

Assignees

@unnoq unnoq

Copilot code review Copilot

Labels

lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@unnoq