Skip to content

Support native plaform Http handlers for Xamarin.Mac #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MIchaelMainer merged 2 commits into from
Apr 10, 2020
Merged

Support native plaform Http handlers for Xamarin.Mac #99

MIchaelMainer merged 2 commits into from
Apr 10, 2020

Conversation

@tipa
Copy link
Contributor

@tipa tipa commented Mar 23, 2020

This PR adds support for native http handler when targeting Xamarin.Mac (NSUrlSessionHandler)

Fixes

#413 Cannot download multiple OneDrive files concurrently since v.1.13.0-beta

@msftclas
Copy link

msftclas commented Mar 23, 2020 •
edited
Loading

CLA assistant check
All CLA requirements met.

@tipa tipa mentioned this pull request Mar 23, 2020
Closed
@peombwa peombwa self-requested a review March 24, 2020 22:18
@MIchaelMainer MIchaelMainer self-assigned this Apr 9, 2020
@MIchaelMainer MIchaelMainer changed the base branch from dev to supportMacHttpHandlers April 10, 2020 21:03
@MIchaelMainer MIchaelMainer merged commit 966f236 into microsoftgraph:supportMacHttpHandlers Apr 10, 2020
@tipa
Copy link
Contributor Author

tipa commented Jul 11, 2020

Any timeline when the msgraph-sdk-dontnet package will use v1.21.0 which contains this change so I can stop using a workaround in my code?

@MIchaelMainer
Copy link
Collaborator

MIchaelMainer commented Jul 23, 2020

@tipa Thank you for following up. Can you confirm that this works as expected in this preview: https://www.nuget.org/packages/Microsoft.Graph.Core/1.21.0-preview.1

@tipa
Copy link
Contributor Author

tipa commented Jul 24, 2020

Unfortunately I cannot test it at the moment as VS for Mac doesn't start on my updated Big Sur machine (https://developercommunity.visualstudio.com/content/problem/1088817/visual-studio-2019-864-crashes-on-mac-os-big-sur.html).
Is it possible the change was merged into 1.20.1 already? That's the package that I am currently using and it seems to work as expected.

@MIchaelMainer
Copy link
Collaborator

MIchaelMainer commented Jul 24, 2020

No, it isn't in 1.20.1. You have to be using your workaround for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peombwa peombwa Awaiting requested review from peombwa

Assignees

@MIchaelMainer MIchaelMainer

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tipa @msftclas @MIchaelMainer