Update master with latest preview features #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds tests to validate similar behavior to HttpProvider - Add modified checks to not authenticate SimpleHttprovider when authprovider is presents - Fixed Ambiguous call in test.
* Improve Error class information * Added Target, Details, and ClientRequestId properties and updated the ToString() method. * Added support for adding the raw response body. **Addresses** * Fixes #23 * Fixes microsoftgraph/msgraph-sdk-dotnet#316
…impleHttpProvider.
… into andrueastman/simplehttpprovider
…vider Add SimpleHttpProvider for GraphClientFactory compatibility
darrelmiller
reviewed
Oct 9, 2019
| /// <param name="baseUrl">The base service URL. For example, "https://graph.microsoft.com/v1.0."</param> | ||
| /// <param name="httpClient">The custom <see cref="HttpClient"/> to be used for making requests</param> | ||
| public BaseClient( | ||
| string baseUrl, |
Contributor
There was a problem hiding this comment.
@MIchaelMainer @peombwa Should we remove the BaseUrl parameter as HttpClient has a BaseAddress property? Or is it better to keep it there for consistency?
Collaborator
Author
There was a problem hiding this comment.
I think we need to keep this. We don't use the BaseAddress set on HttpClient in the service library. We build the URL from the BaseClient.baseUrl IIRC.
We would need to change the PR in the generator if we remove the BaseUrl parameter.
Member
There was a problem hiding this comment.
@darrelmiller I agree with Michael, let's keep it for now. Everything else LGTM.
peombwa
approved these changes
Oct 9, 2019
| /// <param name="baseUrl">The base service URL. For example, "https://graph.microsoft.com/v1.0."</param> | ||
| /// <param name="httpClient">The custom <see cref="HttpClient"/> to be used for making requests</param> | ||
| public BaseClient( | ||
| string baseUrl, |
Member
There was a problem hiding this comment.
@darrelmiller I agree with Michael, let's keep it for now. Everything else LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kicks off a production build. If all goes well, expect a deployment approval request for 1.18.0 after this PR is merged.