Add IBaseRequestBuilder interface to BaseRequestBuilder class
#124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to be the only implementation of a RequestBuilder which doesn't have its corresponding interface?
Author
|
FYI it looks like your pipeline is trying to run in my user context or something and failing based on permissions? (That's outside the scope of this fix, but seems like something that should be investigated) |
Author
|
@MIchaelMainer @darrelmiller any status on this? |
MIchaelMainer
approved these changes
Jul 28, 2020
zengin
approved these changes
Jul 28, 2020
f74aafc
into
microsoftgraph:feature/supportIBaseRequestBuilder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to be the only implementation of a RequestBuilder which doesn't have its corresponding interface?
This is part of a problem (also see https://github.com/microsoftgraph/msgraph-sdk-dotnet/issues/722) for anything use
BaseFunctionMethodRequestBuilderas a RequestBuilder because it doesn't implement the interface and inherits from the base class directly here:msgraph-sdk-dotnet-core/src/Microsoft.Graph.Core/Requests/BaseFunctionMethodRequestBuilder.cs
Line 13 in 61405c1
Therefore things like the
IDriveRecentRequestBuilder's implementation is not compatible to case to a genericIBaseRequestBuilder:https://github.com/microsoftgraph/msgraph-sdk-dotnet/blob/9b74c2674969008669e4c46ac85bda7e6ad8a728/src/Microsoft.Graph/Requests/Generated/DriveRecentRequestBuilder.cs#L19
This prevents a nice common way to receive RequestBuilders for general calls to the graph and make them on behalf of a developer as part of an auxiliary API.