Skip to content

Fix method primitive return type #800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MIchaelMainer merged 6 commits into from
Oct 7, 2020
Merged

Fix method primitive return type #800

MIchaelMainer merged 6 commits into from
Oct 7, 2020

Conversation

@MIchaelMainer
Copy link
Collaborator

@MIchaelMainer MIchaelMainer commented Sep 25, 2020 •
edited
Loading

Methods that return primitives returned JSON objects and not just the OData primitive values. An update needs to occur in the generator and core to support this scenario.

Depends on microsoftgraph/msgraph-sdk-dotnet-core#135. Tests won't pass until this is published.

Generated with microsoftgraph/MSGraph-SDK-Code-Generator#300

The following methods will now be supported:

<Action Name="revokeSignInSessions" IsBound="true" xmlns="http://docs.oasis-open.org/odata/ns/edm">
  <Parameter Name="bindingParameter" Type="graph.user" Nullable="false" />
  <ReturnType Type="Edm.Boolean" />
</Action>
 
<Action Name="addGroup" IsBound="true" xmlns="http://docs.oasis-open.org/odata/ns/edm">
  <Parameter Name="bindingParameter" Type="graph.groupLifecyclePolicy" />
  <Parameter Name="groupId" Type="Edm.String" Nullable="false" Unicode="false" />
  <ReturnType Type="Edm.Boolean" Nullable="false" />
</Action>
 
<Action Name="removeGroup" IsBound="true" xmlns="http://docs.oasis-open.org/odata/ns/edm">
  <Parameter Name="bindingParameter" Type="graph.groupLifecyclePolicy" />
  <Parameter Name="groupId" Type="Edm.String" Nullable="false" Unicode="false" />
  <ReturnType Type="Edm.Boolean" Nullable="false" />
</Action>
 
<Action Name="setMobileDeviceManagementAuthority" IsBound="true" xmlns="http://docs.oasis-open.org/odata/ns/edm">
  <Parameter Name="bindingParameter" Type="graph.organization" />
  <ReturnType Type="Edm.Int32" Nullable="false" />
</Action>
 
<Function Name="count" IsBound="true"
    xmlns="http://docs.oasis-open.org/odata/ns/edm">
    <Parameter Name="bindparameter" Type="Collection(graph.workbookChart)" />
    <ReturnType Type="Edm.Int32" Nullable="false" />
</Function>
--
<Function Name="count" IsBound="true"
    xmlns="http://docs.oasis-open.org/odata/ns/edm">
    <Parameter Name="bindparameter" Type="Collection(graph.workbookTable)" />
    <ReturnType Type="Edm.Int32" Nullable="false" />
</Function>
<Function Name="count" IsBound="true"
    xmlns="http://docs.oasis-open.org/odata/ns/edm">
    <Parameter Name="bindparameter" Type="Collection(graph.workbookTableColumn)" />
    <ReturnType Type="Edm.Int32" Nullable="false" />
</Function>
<Function Name="count" IsBound="true"
    xmlns="http://docs.oasis-open.org/odata/ns/edm">
    <Parameter Name="bindparameter" Type="Collection(graph.workbookTableRow)" />
    <ReturnType Type="Edm.Int32" Nullable="false" />
</Function>
<Function Name="count" IsBound="true"
    xmlns="http://docs.oasis-open.org/odata/ns/edm">
    <Parameter Name="bindparameter" Type="Collection(graph.workbookChartPoint)" />
    <ReturnType Type="Edm.Int32" Nullable="false" />
</Function>
<Function Name="count" IsBound="true"
    xmlns="http://docs.oasis-open.org/odata/ns/edm">
    <Parameter Name="bindparameter" Type="Collection(graph.workbookChartSeries)" />
    <ReturnType Type="Edm.Int32" Nullable="false" />
</Function>
<Function Name="count" IsBound="true"
    xmlns="http://docs.oasis-open.org/odata/ns/edm">
    <Parameter Name="bindparameter" Type="Collection(graph.workbookRangeBorder)" />
    <ReturnType Type="Edm.Int32" Nullable="false" />
</Function>
<Function Name="image" IsBound="true"
    xmlns="http://docs.oasis-open.org/odata/ns/edm">
    <Parameter Name="bindparameter" Type="graph.workbookChart" />
    <ReturnType Type="Edm.String" Unicode="false" />
</Function>
<Function Name="image" IsBound="true"
    xmlns="http://docs.oasis-open.org/odata/ns/edm">
    <Parameter Name="bindparameter" Type="graph.workbookChart" />
    <Parameter Name="width" Type="Edm.Int32" Nullable="false" />
    <ReturnType Type="Edm.String" Unicode="false" />
</Function>
<Function Name="image" IsBound="true"
    xmlns="http://docs.oasis-open.org/odata/ns/edm">
    <Parameter Name="bindparameter" Type="graph.workbookChart" />
    <Parameter Name="width" Type="Edm.Int32" Nullable="false" />
    <Parameter Name="height" Type="Edm.Int32" Nullable="false" />
    <ReturnType Type="Edm.String" Unicode="false" />
</Function>
<Function Name="image" IsBound="true"
    xmlns="http://docs.oasis-open.org/odata/ns/edm">
    <Parameter Name="bindparameter" Type="graph.workbookChart" />
    <Parameter Name="width" Type="Edm.Int32" Nullable="false" />
    <Parameter Name="height" Type="Edm.Int32" Nullable="false" />
    <Parameter Name="fittingMode" Type="Edm.String" Nullable="false" Unicode="false" />
    <ReturnType Type="Edm.String" Unicode="false" />
</Function>
<Function Name="verifyWindowsEnrollmentAutoDiscovery" IsBound="true"
    xmlns="http://docs.oasis-open.org/odata/ns/edm">
    <Parameter Name="bindingParameter" Type="graph.deviceManagement" />
    <Parameter Name="domainName" Type="Edm.String" Unicode="false" />
    <ReturnType Type="Edm.Boolean" Nullable="false" />
</Function>
<Function Name="downloadApplePushNotificationCertificateSigningRequest" IsBound="true"
    xmlns="http://docs.oasis-open.org/odata/ns/edm">
    <Parameter Name="bindingParameter" Type="graph.applePushNotificationCertificate" />
    <ReturnType Type="Edm.String" Unicode="false" />
</Function>

MIchaelMainer and others added 2 commits September 24, 2020 10:45
@MIchaelMainer
Merge pull request #799 from microsoftgraph/dev
76b9eb3 
Release 3.15.0
@MIchaelMainer
Fix methods that return primitives
35647f8 
	modified:   src/Microsoft.Graph/Generated/model/AdministrativeUnit.cs
	modified:   src/Microsoft.Graph/Generated/model/ScopedRoleMembership.cs
	modified:   src/Microsoft.Graph/Generated/requests/ApplePushNotificationCertificateDownloadApplePushNotificationCertificateSigningRequestRequest.cs
	modified:   src/Microsoft.Graph/Generated/requests/DeviceManagementVerifyWindowsEnrollmentAutoDiscoveryRequest.cs
	modified:   src/Microsoft.Graph/Generated/requests/GroupLifecyclePolicyAddGroupRequest.cs
	modified:   src/Microsoft.Graph/Generated/requests/GroupLifecyclePolicyRemoveGroupRequest.cs
	modified:   src/Microsoft.Graph/Generated/requests/OrganizationSetMobileDeviceManagementAuthorityRequest.cs
	modified:   src/Microsoft.Graph/Generated/requests/UserRevokeSignInSessionsRequest.cs
	modified:   src/Microsoft.Graph/Generated/requests/WorkbookChartCountRequest.cs
	modified:   src/Microsoft.Graph/Generated/requests/WorkbookChartImageRequest.cs
	modified:   src/Microsoft.Graph/Generated/requests/WorkbookChartPointCountRequest.cs
	modified:   src/Microsoft.Graph/Generated/requests/WorkbookChartSeriesCountRequest.cs
	modified:   src/Microsoft.Graph/Generated/requests/WorkbookRangeBorderCountRequest.cs
	modified:   src/Microsoft.Graph/Generated/requests/WorkbookTableColumnCountRequest.cs
	modified:   src/Microsoft.Graph/Generated/requests/WorkbookTableCountRequest.cs
	modified:   src/Microsoft.Graph/Generated/requests/WorkbookTableRowCountRequest.cs
@MIchaelMainer MIchaelMainer mentioned this pull request Sep 25, 2020
Merged
@MIchaelMainer MIchaelMainer marked this pull request as ready for review September 25, 2020 06:56
zengin
zengin previously approved these changes Sep 25, 2020
View reviewed changes
nikithauc
nikithauc previously approved these changes Oct 6, 2020
View reviewed changes
@MIchaelMainer MIchaelMainer mentioned this pull request Oct 6, 2020
Closed
3 tasks
zengin
zengin previously approved these changes Oct 6, 2020
View reviewed changes
@MIchaelMainer MIchaelMainer dismissed stale reviews from zengin and nikithauc via bd4b3c3 October 6, 2020 06:44
@MIchaelMainer MIchaelMainer merged commit efc7a4c into dev Oct 7, 2020
@MIchaelMainer MIchaelMainer deleted the fix/methodPrimitiveReturnType branch October 7, 2020 07:47
@zengin zengin mentioned this pull request Oct 8, 2020
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@baywet baywet Awaiting requested review from baywet

2 more reviewers

@zengin zengin zengin approved these changes

@nikithauc nikithauc nikithauc left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MIchaelMainer @zengin @nikithauc