Skip to content

Fix for response headers and status codes data in entities during update #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MIchaelMainer merged 18 commits into from
May 30, 2019
Merged

Fix for response headers and status codes data in entities during update #485

MIchaelMainer merged 18 commits into from
May 30, 2019

Conversation

@irvinesunday
Copy link
Contributor

@irvinesunday irvinesunday commented May 29, 2019

Fixes #426

Changes proposed in this pull request

  • EntityRequest classes have been updated with property checking validation in the async UpdateAsync() method which inspects the AdditionalData property bag for the presence of response headers and status code data. If these are found, a ClientException is thrown with the message: "Do not use objects returned in a response for updating an object in Microsoft Graph. Create a new <class name> object and only set the updated properties on it."
  • A test method UpdateAsync_EntityWithResponseHeadersAndStatusCode() has been added to validate this check.

Other links

Irvine Sunday added 16 commits May 21, 2019 14:54
Adding HTTP property names in a constant class
2c1eb36 
Since these string values will be used severally across the project.
Passing HTTP property names as string constants
1f511a7
Removing responseHeaders and statusCode key, values
1029e49 
Removing these from the AdditionalData property bag to avoid them being serialized when request is sent to the service
Adding test for UpdateAsync_EntityWithResponseHeadersAndStatusCode
ac58c4a 
ClientError Exception should be thrown
Throwing ClientException if response headers and status codes are found
e3bb1d7
Adding class for generated error constants
20d19e2
Using constant values in place of text
4814ac2
Adding error message to list of constants
34d2440
Removing test from Core into Graph
e09e291
Moving test into Graph from Core
b08e0cb
Revert "Passing HTTP property names as string constants"
c6d990d 
This reverts commit 1f511a7.
Revert "Adding HTTP property names in a constant class"
2137672 
This reverts commit 2c1eb36.
Adding HTTP property names in a constant class in Graph
e08985d
Merge remote-tracking branch 'origin/dev' into is/response-headers-fix
5e47246
Adding XUnit test to validate response headers / status code fix
01928d8
Copying generated files from the SDK-Code-Generator
5d8f100 
Copying into the appropriate generated folders.
MIchaelMainer
MIchaelMainer requested changes May 29, 2019
View reviewed changes
peombwa
peombwa requested changes May 29, 2019
View reviewed changes
Uploading generated files with spacing indentation fixes
027a3b4 
Spacing is used in place of tabs; for uniformity
@MIchaelMainer MIchaelMainer merged commit 6cc1968 into dev May 30, 2019
@MIchaelMainer MIchaelMainer deleted the is/response-headers-fix branch May 30, 2019 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peombwa peombwa peombwa approved these changes

@MIchaelMainer MIchaelMainer MIchaelMainer approved these changes

@titusgicheru titusgicheru Awaiting requested review from titusgicheru

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove response header properties from serialized requests

4 participants

@irvinesunday @peombwa @MIchaelMainer