Skip to content

Adds constructor to GraphServiceClient template #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MIchaelMainer merged 2 commits into from
Oct 10, 2019
Merged

Adds constructor to GraphServiceClient template #221

MIchaelMainer merged 2 commits into from
Oct 10, 2019

Conversation

@andrueastman
Copy link
Contributor

@andrueastman andrueastman commented Sep 25, 2019 •
edited
Loading

This PR modifies the template for the GraphServiceClient to add a new constructor to add support for the following scenario

  HttpClient client = GraphClientFactory.Create(...);
  var graphServiceClient = new GraphServiceClient(client);

This PR is related to

@andrueastman andrueastman mentioned this pull request Sep 25, 2019
Merged
@andrueastman andrueastman self-assigned this Sep 25, 2019
MIchaelMainer
MIchaelMainer reviewed Sep 25, 2019
View reviewed changes
@MIchaelMainer
Copy link
Collaborator

MIchaelMainer commented Oct 3, 2019

This PR is all good. Let's not take this in until after 1.18.0 is published out of preview.

https://www.nuget.org/packages/Microsoft.Graph.Core

@andrueastman
Copy link
Contributor Author

andrueastman commented Oct 4, 2019

Agreed.

@MIchaelMainer MIchaelMainer merged commit be3c6af into dev Oct 10, 2019
@andrueastman andrueastman deleted the andrueastman/add-graphserviceclient-constructor branch November 25, 2019 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MIchaelMainer MIchaelMainer MIchaelMainer approved these changes

@irvinesunday irvinesunday Awaiting requested review from irvinesunday

@darrelmiller darrelmiller Awaiting requested review from darrelmiller

Assignees

@andrueastman andrueastman

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andrueastman @MIchaelMainer