Implicit containment #121
Merged
Implicit containment #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
February 7, 2018 11:17
Handles the case where a singleton has a navigation property that defines an implicit EntitySet using "ContainsTarget="true"". This allows us to generate code that correctly lets workloads navigate from a child object to a singleton's implicit EntitySet by $ref
This is for the C# generated templates. Currently in the templates, we generate @odata.id based off an EntitySet name, which is an absolute URL. In the case of a singleton, we want to navigate to that singleton's relevant EntitySet
…ode-generator into implicit-containment
Also added a reference to the VIPR reader
Tests for GetServiceCollectionNavigationPropertyForPropertyType method
MIchaelMainer
approved these changes
Feb 16, 2018
Collaborator
MIchaelMainer
left a comment
There was a problem hiding this comment.
Looks good. Thank you for doing the multi platform update. Regarding Java, will the Android update in to Java?
Author
|
It will not. I made a separate branch "implicit-containment-java" that is a branch off of "Java". Once I merge the Java branch we won't have to do this anymore. Sorry for the confusion. |
Collaborator
|
You rock!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handles the case where a navigation property references an implicit EntitySet of a singleton.