Dev update method request #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…CredentialsRequestBuilder. While the ValidateCredentials action is overloaded, we don't handle this scenario here. There is a collection request builder for jobs where the validateCreentials action is called.
| /// <param name="<#=returnEntityParameter#>">The <#=returnEntityType#> object set with the properties to update.</param> | ||
| /// <returns>The task to await for async call.</returns> | ||
| public <#=methodReturnType#> PatchAsync(<#=returnEntityType#> <#=returnEntityParameter#>) | ||
| public <#=methodOverloadReturnType#> PatchAsync(<#=returnEntityType#> <#=returnEntityParameter#>) |
There was a problem hiding this comment.
These two variables seem to have the same value throughout the file (assignment at line 33)
Collaborator
Author
There was a problem hiding this comment.
They are the same unless the return type is a collection.
caitlinrussell
approved these changes
Nov 20, 2017
Collaborator
Author
|
Generated with these changes against the last version of the metadata that we used to generate the client library. No code changes were generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verified through diff that these changes do not affect the existing client library. This should fix the generation issues.